GRAMPS › GRAMPS - Dev

5466: On import and Check and Repair need to check references to absent objects

Classic

List

Threaded

5 messages Options

Nick Hall-6

5466: On import and Check and Repair need to check references to absent objects

Hi,

I have a few concerns about this fix regarding tagging.

1. Ideally the tag name should be unique. There is another bug raised
about duplicate tag names on import.
2. The priorities should be unique consecutive integers.
3. The tag list in objects is unordered. This makes the code to
replace/merge over complicated.

Does anyone have any preferences about how we import tags with the same
name as a tag already in the database?

Regards,

Nick.

------------------------------------------------------------------------------
For Developers, A Lot Can Happen In A Second.
Boundary is the first to Know...and Tell You.
Monitor Your Applications in Ultra-Fine Resolution. Try it FREE!
http://p.sf.net/sfu/Boundary-d2dvs2
_______________________________________________
Gramps-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gramps-devel

robhealey1

Re: 5466: On import and Check and Repair need to check references to absent objects

Dear Nick:

My only comment would be that each tag name should be unique
especially if there is already an existing tag with the same name!

Sincerely yours,
Rob G. Healey

On Sat, Apr 14, 2012 at 11:01 AM, Nick Hall <[hidden email]> wrote:

> Hi,
>
> I have a few concerns about this fix regarding tagging.
>
> 1. Ideally the tag name should be unique. There is another bug raised
> about duplicate tag names on import.
> 2. The priorities should be unique consecutive integers.
> 3. The tag list in objects is unordered. This makes the code to
> replace/merge over complicated.
>
> Does anyone have any preferences about how we import tags with the same
> name as a tag already in the database?
>
> Regards,
>
> Nick.
>
>
> ------------------------------------------------------------------------------
> For Developers, A Lot Can Happen In A Second.
> Boundary is the first to Know...and Tell You.
> Monitor Your Applications in Ultra-Fine Resolution. Try it FREE!
> http://p.sf.net/sfu/Boundary-d2dvs2
> _______________________________________________
> Gramps-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/gramps-devel

--
Sincerely yours,
Rob G. Healey

------------------------------------------------------------------------------
For Developers, A Lot Can Happen In A Second.
Boundary is the first to Know...and Tell You.
Monitor Your Applications in Ultra-Fine Resolution. Try it FREE!
http://p.sf.net/sfu/Boundary-d2dvs2
_______________________________________________
Gramps-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gramps-devel

Benny Malengier

Re: 5466: On import and Check and Repair need to check references to absent objects

In reply to this post by Nick Hall-6

Adding automatically a number to the end seems like a common approach to these kind of problems.
If there was already a number at the end, increasing it by one.

Benny

2012/4/14 Nick Hall <[hidden email]>

Hi,

I have a few concerns about this fix regarding tagging.

1. Ideally the tag name should be unique. There is another bug raised
about duplicate tag names on import.
2. The priorities should be unique consecutive integers.
3. The tag list in objects is unordered. This makes the code to
replace/merge over complicated.

Does anyone have any preferences about how we import tags with the same
name as a tag already in the database?

Regards,

Nick.

------------------------------------------------------------------------------
For Developers, A Lot Can Happen In A Second.
Boundary is the first to Know...and Tell You.
Monitor Your Applications in Ultra-Fine Resolution. Try it FREE!
http://p.sf.net/sfu/Boundary-d2dvs2
_______________________________________________
Gramps-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gramps-devel

------------------------------------------------------------------------------
For Developers, A Lot Can Happen In A Second.
Boundary is the first to Know...and Tell You.
Monitor Your Applications in Ultra-Fine Resolution. Try it FREE!
http://p.sf.net/sfu/Boundary-d2dvs2
_______________________________________________
Gramps-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gramps-devel

Tim Lyons

Re: 5466: On import and Check and Repair need to check references to absent objects

In reply to this post by Nick Hall-6

Nick Hall-6 wrote

Does anyone have any preferences about how we import tags with the same
name as a tag already in the database?

I'd suggest a suffix of (n) where n starts at one and is incremented if that number already exists.

Do you want to make a change to the tagging code before the release of 3.4.0, or is it perhaps the case that it is not any worse that it already was with the bug about duplicate tags? (I presume that the ordering of the tag list in objects is a change that is not particularly related to the fix, so is not newly urgent).

Regards,
Tim.

Michiel Nauta

Re: 5466: On import and Check and Repair need to check references to absent objects

In reply to this post by Nick Hall-6

Hi,

I don't like exceptions so since we do no "merge on import" for other
elements, I do not want it for tags either.

I added a possible patch on the bugtracker 5655.

Michiel

P.S. I think this has little to do with 5466, it is trouble that already
existed before that patch was applied.

On 04/14/2012 08:01 PM, Nick Hall wrote: