ChangeLog and .deb questions

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

ChangeLog and .deb questions

Stéphane Charette-2
Where does the dependency on po/ChangeLog come from?

For example, try to run the command "make distcheck".  It dies because
po/ChangeLog doesn't exist.

Looks like autogen.sh is responsible for po/Makefile*.  I can see this message:

    "Copying file po/Makefile.in.in"

...but I cannot figure out where that message is coming from, nor from
where it is copying the file.

I also see the debian directory has dependencies on ChangeLog.  Unless
someone has objections, I plan on changing this line:

    debian/rules:   dh_installchangelogs --package=gramps ChangeLog
...to instead say:
    debian/rules:   dh_installchangelogs --package=gramps

If you happen to know if this is the wrong solution, please let me know.

Stéphane

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Gramps-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gramps-devel
Reply | Threaded
Open this post in threaded view
|

Re: ChangeLog and .deb questions

Alex Roitman
Stéphane,

On Wed, 2008-03-19 at 22:00 -0700, Stéphane Charette wrote:

> Where does the dependency on po/ChangeLog come from?
>
> For example, try to run the command "make distcheck".  It dies because
> po/ChangeLog doesn't exist.
>
> Looks like autogen.sh is responsible for po/Makefile*.  I can see this message:
>
>     "Copying file po/Makefile.in.in"
>
> ...but I cannot figure out where that message is coming from, nor from
> where it is copying the file.
>
> I also see the debian directory has dependencies on ChangeLog.  Unless
> someone has objections, I plan on changing this line:
>
>     debian/rules:   dh_installchangelogs --package=gramps ChangeLog
> ...to instead say:
>     debian/rules:   dh_installchangelogs --package=gramps
>
> If you happen to know if this is the wrong solution, please let me know.
In my understanding, Brian proposed generating ChangeLog
from svn logs. If so then there's no need to avoid
ChangeLog -- just generate it before the release.

It is definitely a good idea to ship ChangeLog files with
the released code. It is also the requirement of the GPL
to document all the changes made to the code.

Alex


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Gramps-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gramps-devel

signature.asc (196 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: ChangeLog and .deb questions

Stéphane Charette-2
>  > For example, try to run the command "make distcheck".  It dies because
>  > po/ChangeLog doesn't exist.

>  In my understanding, Brian proposed generating ChangeLog
>  from svn logs. If so then there's no need to avoid
>  ChangeLog -- just generate it before the release.
>
>  It is definitely a good idea to ship ChangeLog files with
>  the released code. It is also the requirement of the GPL
>  to document all the changes made to the code.

Just so everyone understands, I have no problem with the fact the
ChangeLog file is gone.  Actually, I prefer to have our changes in the
SVN log.

But I do have a problem with generating a ChangeLog just for the
purpose of building a release.  When we take a revision from SVN, the
build for that revision should be easy to duplicate.  But now whenever
someone checks out a 3.+ release tag, it will fail to build.  There
are additional steps/changes required to get a build started!  This
sounds like the wrong thing.

I would say we have 3 options:

1) remove the dependency on ChangeLog from the build process (run
"make distcheck" and you'll see the failure)
2) add an empty ChangeLog file, or one telling people the ChangeLog is
now available from <URL> or an SVN command
3) add to the build process the steps required to dynamically build
the ChangeLog file

Think of it this way:  The Debian guys who are not on this mailing
list and don't participate on GRAMPS will eventually see we have a new
version.  Technically, they could check out tag "3.0.0" from SVN and
attempt to build it and create a .deb file.  But the build will fail.
When you check out an official version from a software repository, you
don't expect to have to make further modifications before it will
build.

Stéphane

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Gramps-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gramps-devel
Reply | Threaded
Open this post in threaded view
|

Re: ChangeLog and .deb questions

Stéphane Charette-2
I should have added:

Note that all of this is not about ChangeLog, but about po/ChangeLog.

Stéphane


On Thu, Mar 20, 2008 at 9:20 AM, Stéphane Charette
<[hidden email]> wrote:

> >  > For example, try to run the command "make distcheck".  It dies because
>  >  > po/ChangeLog doesn't exist.
>
>
> >  In my understanding, Brian proposed generating ChangeLog
>  >  from svn logs. If so then there's no need to avoid
>  >  ChangeLog -- just generate it before the release.
>  >
>  >  It is definitely a good idea to ship ChangeLog files with
>  >  the released code. It is also the requirement of the GPL
>  >  to document all the changes made to the code.
>
>  Just so everyone understands, I have no problem with the fact the
>  ChangeLog file is gone.  Actually, I prefer to have our changes in the
>  SVN log.
>
>  But I do have a problem with generating a ChangeLog just for the
>  purpose of building a release.  When we take a revision from SVN, the
>  build for that revision should be easy to duplicate.  But now whenever
>  someone checks out a 3.+ release tag, it will fail to build.  There
>  are additional steps/changes required to get a build started!  This
>  sounds like the wrong thing.
>
>  I would say we have 3 options:
>
>  1) remove the dependency on ChangeLog from the build process (run
>  "make distcheck" and you'll see the failure)
>  2) add an empty ChangeLog file, or one telling people the ChangeLog is
>  now available from <URL> or an SVN command
>  3) add to the build process the steps required to dynamically build
>  the ChangeLog file
>
>  Think of it this way:  The Debian guys who are not on this mailing
>  list and don't participate on GRAMPS will eventually see we have a new
>  version.  Technically, they could check out tag "3.0.0" from SVN and
>  attempt to build it and create a .deb file.  But the build will fail.
>  When you check out an official version from a software repository, you
>  don't expect to have to make further modifications before it will
>  build.
>
>  Stéphane
>

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Gramps-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gramps-devel
Reply | Threaded
Open this post in threaded view
|

Re: ChangeLog and .deb questions

Alex Roitman
In reply to this post by Stéphane Charette-2
On Thu, 2008-03-20 at 09:22 -0700, Stéphane Charette wrote:
> I should have added:
>
> Note that all of this is not about ChangeLog, but about po/ChangeLog.

Ah! That means the intltool is the culprit.
I did intltool-ize gramps some time ago, but it was a mess. I distinctly
remember putting po/ChangeLog in there because it would fail
to work without. I have no idea on how to fix this, sorry.

> Think of it this way:  The Debian guys who are not on this mailing
> list and don't participate on GRAMPS will eventually see we have a new
> version.  Technically, they could check out tag "3.0.0" from SVN and
> attempt to build it and create a .deb file.  But the build will fail.
> When you check out an official version from a software repository, you
> don't expect to have to make further modifications before it will
> build.

The debian dir is not for Debian. In fact, our Debian maintainer
asked to not package it in the released tarball. This dir is for
making Ubuntu packages by gramps volunteers (Ubuntu packages made
by Ubuntu guys also don't use our debian dir).

In any case, the whole line including ChangeLog can be
deleted from debian/rules to fix this issue.

Alex

--
Alexander Roitman   http://gramps-project.org

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Gramps-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gramps-devel

signature.asc (196 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: ChangeLog and .deb questions

Stéphane Charette-2
>  In any case, the whole line including ChangeLog can be
>  deleted from debian/rules to fix this issue.

Running "make distcheck" doesn't use the debian directory, does it?

I cannot get the source together when we have a release if I cannot
run "make distcheck".  Which is why I had those 3 suggestions for
dealing with po/ChangeLog.

Stéphane

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Gramps-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gramps-devel
Reply | Threaded
Open this post in threaded view
|

Re: ChangeLog and .deb questions

Jay Treacy
In reply to this post by Alex Roitman
On Thu, Mar 20, 2008 at 10:20:21AM -0700, Alex Roitman wrote:

> > Think of it this way:  The Debian guys who are not on this mailing
> > list and don't participate on GRAMPS will eventually see we have a new
> > version.  Technically, they could check out tag "3.0.0" from SVN and
> > attempt to build it and create a .deb file.  But the build will fail.
> > When you check out an official version from a software repository, you
> > don't expect to have to make further modifications before it will
> > build.
>
> The debian dir is not for Debian. In fact, our Debian maintainer
> asked to not package it in the released tarball. This dir is for
> making Ubuntu packages by gramps volunteers (Ubuntu packages made
> by Ubuntu guys also don't use our debian dir).

It turns out that at least one Debian developer reads this list. In
fact, I am the one Alex referred to above and have been packaging
gramps for Debian for almost 6 years.

If you are interested in the build system that Debian uses, you can
use (assuming an appropriate deb-src line in /etc/apt/sources.list):

# apt-get source gramps

> In any case, the whole line including ChangeLog can be
> deleted from debian/rules to fix this issue.

Feel free to not install the ChangeLog in your personal package.
For wider distribution it should be included. It is a
requirement for official Debian packages.

--
                       A: Because it messes up the order in which people normally read text.
James Treacy           Q: Why is top-posting such a bad thing?
[hidden email]      A: Top-posting.
                       Q: What is the most annoying thing in e-mail?

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Gramps-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gramps-devel
Reply | Threaded
Open this post in threaded view
|

Re: ChangeLog and .deb questions

Alex Roitman
In reply to this post by Stéphane Charette-2
On Thu, 2008-03-20 at 10:34 -0700, Stéphane Charette wrote:
> >  In any case, the whole line including ChangeLog can be
> >  deleted from debian/rules to fix this issue.
>
> Running "make distcheck" doesn't use the debian directory, does it?

No.
I only responded to the debian/rules entry because you brought it up.

> I cannot get the source together when we have a release if I cannot
> run "make distcheck".  Which is why I had those 3 suggestions for
> dealing with po/ChangeLog.

Right. The "touch po/ChangeLog" fixes things for that purpose.

Seems that the glib-gettextize call is responsible for
copying pre-determined stuff into po/Makefile.in.in and that
refers to ChangeLog. Seems beyond our control, short of
filing bugs against libglib2.0-dev package.

So I guess having something in place of ChangeLog is a good
short-term solution.

Alex

--
Alexander Roitman   http://gramps-project.org

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Gramps-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gramps-devel

signature.asc (196 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: ChangeLog and .deb questions

Brian Matherly
In reply to this post by Stéphane Charette-2
Stephane,

> >  In any case, the whole line including ChangeLog
> can be
> >  deleted from debian/rules to fix this issue.
>
> Running "make distcheck" doesn't use the debian
> directory, does it?
>
> I cannot get the source together when we have a
> release if I cannot
> run "make distcheck".  Which is why I had those 3
> suggestions for
> dealing with po/ChangeLog.

Regarding po/ChangeLog:
I don't plan on ever creating a ChangeLog file for po.
So I hope we can figure out how to work around that so
we don't need it to build a release.

Regarding src/ChangeLog:
When we create a release, it is my intention to create
a ChangeLog and commit that ChangeLog to SVN in the
tag for that release. For example, when we release
3.0.0, the process will go like this:

1) Create "tags/gramps300" from "branches/gramps30".
2) Create a ChangeLog
3) Commit the ChangeLog to "tags/gramps300/src/"
4) Export "tags/gramps300"
5) Create a release from the exported files

All package maintainers should use the package that we
(you) create. If for some reason they choose to get
the files from SVN, they will get the files from the
tag and it will have a ChangeLog.

~Brian



-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Gramps-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gramps-devel