|
Here's an updated patch to both import and export name types. According
to one resource (http://www.gencom.org.nz/GEDCOM_tags.html) it looks like _MARN and _MARNM are equivalent. With this patch, _MAR, _MARN, and _MARNM are treated the same by GRAMPS. I have a file generated by "Genbox" from "Thoughtful Creations" that exports name types as: 0 @I46@ INDI 1 NAME Virginia /Jones/ 1 NAME Virginia /Smith/ 2 _TYPE _MARN The patch also adds handling for this format. -- Gabriel Burca ------------------------------------------------------------------------------ Virtualization & Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ _______________________________________________ Gramps-devel mailing list [hidden email] https://lists.sourceforge.net/lists/listinfo/gramps-devel |
|
Gabriel,
Thanks for the patch. Tim is looking at the Gedcom Import/Export at the moment so he will be in a good position to look at this. It looks OK to me though, but I have a couple of comments. Should we be using TYPE rather than _TYPE on the export? PERSONAL_NAME_STRUCTURE:= n NAME <NAME_PERSONAL> +1 TYPE <NAME_TYPE> +1 <<PERSONAL_NAME_PIECES>> +1 FONE <NAME_PHONETIC_VARIATION> +2 TYPE <PHONETIC_TYPE> +2 <<PERSONAL_NAME_PIECES>> +1 ROMN <NAME_ROMANIZED_VARIATION> +2 TYPE <ROMANIZED_TYPE> +2 <<PERSONAL_NAME_PIECES>> It is neater to write: if line.data in ("_OTHN", "_AKA"): rather than if line.data == "_OTHN" or line.data == "_AKA": Regards, Nick. On 01/03/12 07:03, Gabriel Burca wrote: Here's an updated patch to both import and export name types. According to one resource (http://www.gencom.org.nz/GEDCOM_tags.html) it looks like _MARN and _MARNM are equivalent. With this patch, _MAR, _MARN, and _MARNM are treated the same by GRAMPS. I have a file generated by "Genbox" from "Thoughtful Creations" that exports name types as: 0 @I46@ INDI 1 NAME Virginia /Jones/ 1 NAME Virginia /Smith/ 2 _TYPE _MARN The patch also adds handling for this format.------------------------------------------------------------------------------ Virtualization & Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/_______________________________________________ Gramps-devel mailing list [hidden email] https://lists.sourceforge.net/lists/listinfo/gramps-devel ------------------------------------------------------------------------------ Virtualization & Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ _______________________________________________ Gramps-devel mailing list [hidden email] https://lists.sourceforge.net/lists/listinfo/gramps-devel |
|
On 03/01/2012 05:10 AM, Nick Hall wrote:
> Should we be using TYPE rather than _TYPE on the export? You're right. The version of the standard I was looking at didn't have TYPE, but I see now that v5.5.1 has it. I re-generated the patch based on your comments, and I also changed the export to use standard strings for the type ("aka" and "married" instead of _AKA and _MARN). NAME_TYPE:= [ aka | birth | immigrant | maiden | married | <user defined>] I've attached the new patch. Hopefully Tim can pull it in. -- Gabriel Burca ------------------------------------------------------------------------------ Virtualization & Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ _______________________________________________ Gramps-devel mailing list [hidden email] https://lists.sourceforge.net/lists/listinfo/gramps-devel |
|
Gabriel,
Thanks very much for the comments, and supplying a patch. As Nick implies, I don't think we should output non-standard GEDCOM, so your new change for export fixes that - I must say I am surprised that there is no differentiation in the current code in the output is multiple names. I suppose that is because the output claims to be GEDCOM 5.5, although it does include some elements of 5.5.1. I will certainly include your suggestion. However, I wonder whether we should use the predefined type names in gen.lib.NameType preferentially. gen.lib.NameType._DATAMAP has a mapping from AKA to "Also Known As", and I think we should use that. However, I am keen to find real examples of any non-standard GEDCOM. The example I have found of the use of _MARN (http://genealog.dk/comp.ged) shows that it is followed by DATE, and as Gramps supports dates associated with names, it would be nice to include that. I will add your code in the next couple of days or so. Again, thanks for the contribution. Tim. |
|
On 4 Mar 2012, at 15:10, Tim Lyons [via GRAMPS] wrote: However, I wonder whether we should use the predefined type names in gen.lib.NameType preferentially. gen.lib.NameType._DATAMAP has a mapping from AKA to "Also Known As", and I think we should use that. Sorry, that was rubbish. I had not looked (as you obviously had) at the spec of NAME_TYPE in GEDCOM 5.5.1 (as below to avoid further confusion!) NAME_TYPE:= {Size=5:30} [ aka | birth | immigrant | maiden | married | <user defined>] Indicates the name type, for example the name issued or assumed as an immigrant. aka = also known as, alias, etc. birth = name given on birth certificate. immigrant = name assumed at the time of immigration. maiden = maiden name, name before first marriage. married = name was persons previous married name. user_defined= other text name that defines the name type. Again, thanks for the contribution. ------------------------------------------------------------------------------ Keep Your Developer Skills Current with LearnDevNow! The most comprehensive online learning library for Microsoft developers is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, Metro Style Apps, more. Free future releases when you subscribe now! http://p.sf.net/sfu/learndevnow-d2d _______________________________________________ Gramps-devel mailing list [hidden email] https://lists.sourceforge.net/lists/listinfo/gramps-devel |
| Powered by Nabble | Edit this page |
