GRAMPS › GRAMPS - Dev

GEPS 011: Tagging update

Classic

List

Threaded

16 messages Options

Nick Hall-6

GEPS 011: Tagging update

Devs,

I have just committed a new version of the Tagging functionality to
trunk (r15921).

In the new version, tags are a new object type called a Table object
(TableObj). Table objects are intended to provide much of the database
functionality of Primary objects. They are stored in their own table,
they emit 'add', 'update', 'delete' and 'rebuild' signals, they have a
last-change time and changes to them can be undone. They also benefit
from the reference tables that Primary objects use. However, they do
not have a Gramps ID and should not be presented to the end-user as
Primary objects.

As such, Tag objects support all of the database methods that you would
expect from a primary object:

get_tag_handles
get_tag_from_handle
iter_tags
iter_tag_handles
has_tag_handle
get_number_of_tags
add_tag
remove_tag
commit_tag

Tags do not have a Gramps ID so there is no method to get a tag from an
ID, but you can get the tag from a tag name using:

get_tag_from_name

Primary objects that support tagging (only Person at the moment) have
the following methods to access their tags:

get_tag_list
set_tag_list
add_tag
remove_tag

It is also possible to find which objects are tagged with a given tag
using find_backlink_handles.

The functionality for this update is the same as before, except that now
the order of tags is important in the Tag Organiser. Tags at the top of
the list have higher priority when colouring a row with multiple tags.
You shouldn't notice any other changes in this update.

This update allows full undo functionality for Tags, which was not
possible before.

The limitations are still the same. I have implemented this for people
only at the moment, and I still haven't written the import/export to xml
yet.

Note: If you have been using tags please start from an empty database
and import a new xml file, or upgrade from a 3.2 format file.

Let me know if you have any problems.

Regards,

Nick.

------------------------------------------------------------------------------
Start uncovering the many advantages of virtual appliances
and start using them to simplify application deployment and
accelerate your shift to cloud computing.
http://p.sf.net/sfu/novell-sfdev2dev
_______________________________________________
Gramps-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gramps-devel

Peter Landgren

Re: GEPS 011: Tagging update

Nick,

I don't know if this has to do with tagging or not, but
when I unmark the a column in the person View I get:

ERROR .: Unhandled exception
Traceback (most recent call last):
File "/home/peter/svn/GRAMPSTRUNK/trunk/src/gui/columnorder.py", line 166, in __on_apply
node = self.model.get_iter((int(i), ))
ValueError: invalid tree path

It works in the other views.

A tag question:

You show the tags in alphabetic order, but the color used is for the top tag in the tag list.

BTW, I have translated tag to flag (in Swedish flagga)

/Peter

------------------------------------------------------------------------------
Start uncovering the many advantages of virtual appliances
and start using them to simplify application deployment and
accelerate your shift to cloud computing.
http://p.sf.net/sfu/novell-sfdev2dev
_______________________________________________
Gramps-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gramps-devel

jerome

Re: GEPS 011: Tagging update

Maybe you should remove your .ini files (gramps33) for views using tag column, like previous DB upgrade ?

--- En date de : Mer 22.9.10, Peter Landgren <[hidden email]> a écrit :

> De: Peter Landgren <[hidden email]>
> Objet: Re: [Gramps-devel] GEPS 011: Tagging update
> À: [hidden email]
> Date: Mercredi 22 septembre 2010, 9h53
> Nick,
>
> I don't know if this has to do with tagging or not, but
> when I unmark the a column in the person View I get:
>
> ERROR .: Unhandled exception
> Traceback (most recent call last):
> File
> "/home/peter/svn/GRAMPSTRUNK/trunk/src/gui/columnorder.py",
> line 166, in __on_apply
> node = self.model.get_iter((int(i), ))
> ValueError: invalid tree path
>
> It works in the other views.
>
> A tag question:
>
> You show the tags in alphabetic order, but the color used
> is for the top tag in the tag list.
>
> BTW, I have translated tag to flag (in Swedish flagga)
>
> /Peter
>
> ------------------------------------------------------------------------------
> Start uncovering the many advantages of virtual appliances
> and start using them to simplify application deployment
> and
> accelerate your shift to cloud computing.
> http://p.sf.net/sfu/novell-sfdev2dev
> _______________________________________________
> Gramps-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/gramps-devel
>

------------------------------------------------------------------------------
Start uncovering the many advantages of virtual appliances
and start using them to simplify application deployment and
accelerate your shift to cloud computing.
http://p.sf.net/sfu/novell-sfdev2dev
_______________________________________________
Gramps-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gramps-devel

Peter Landgren

Re: GEPS 011: Tagging update

Jerome,

Thanks, It works now. I know I should do this, but memory is ...

/Peter

> Maybe you should remove your .ini files (gramps33) for views using tag
> column, like previous DB upgrade ?
>
> --- En date de : Mer 22.9.10, Peter Landgren <[hidden email]> a écrit :
> > De: Peter Landgren <[hidden email]>
> > Objet: Re: [Gramps-devel] GEPS 011: Tagging update
> > À: [hidden email]
> > Date: Mercredi 22 septembre 2010, 9h53
> > Nick,
> >
> > I don't know if this has to do with tagging or not, but
> > when I unmark the a column in the person View I get:
> >
> > ERROR .: Unhandled exception
> > Traceback (most recent call last):
> > File
> > "/home/peter/svn/GRAMPSTRUNK/trunk/src/gui/columnorder.py",
> > line 166, in __on_apply
> > node = self.model.get_iter((int(i), ))
> > ValueError: invalid tree path
> >
> > It works in the other views.
> >
> > A tag question:
> >
> > You show the tags in alphabetic order, but the color used
> > is for the top tag in the tag list.
> >
> > BTW, I have translated tag to flag (in Swedish flagga)
> >
> > /Peter
> >
> > -------------------------------------------------------------------------
> > ----- Start uncovering the many advantages of virtual appliances
> > and start using them to simplify application deployment
> > and
> > accelerate your shift to cloud computing.
> > http://p.sf.net/sfu/novell-sfdev2dev
> > _______________________________________________
> > Gramps-devel mailing list
> > [hidden email]
> > https://lists.sourceforge.net/lists/listinfo/gramps-devel

Nick Hall-6

Re: GEPS 011: Tagging update

In reply to this post by Peter Landgren

Peter,

Before the update I stored the tag lists alphabetically. Now I store
them in the order they are added, except after editing them in the
person editor which saves them in alphabetic order.

I have a few options:

1. Continue to display them in alphabetic order.

2. Display them in the order they are added to the person. If this is
the case, I should make sure that in the person editor new tags are
added to the end of the list instead of re-ordering it alphabetically.

3. Display the list in priority order. This is the order of the tags in
the Tag Organizer.

Because the tags are not stored in any particular order, at the moment,
I sort them in the model when they are displayed. Changing the sort
order would be very easy.

Option 1 has the advantage that, if we had performance problems in the
views, we could store the tags in alphabetic order at the expense of
making the operation of adding tags slower.

Option 2 is obviously best from a performance point of view.

Option 3 would not store the tags in priority order since this order can
be changed by the user.

Perhaps we should wait to see if anyone, especially with large
databases, has any performance problems before making a final decision.

"Flag" is fine for the translation although the icon will not be
consistent. I suggested "Flag", "Marker" and "Label" as alternatives in
an earlier post.

Regards,

Nick.

Peter Landgren wrote:

> Nick,
>
> I don't know if this has to do with tagging or not, but
> when I unmark the a column in the person View I get:
>
> ERROR .: Unhandled exception
> Traceback (most recent call last):
> File "/home/peter/svn/GRAMPSTRUNK/trunk/src/gui/columnorder.py", line 166, in __on_apply
> node = self.model.get_iter((int(i), ))
> ValueError: invalid tree path
>
> It works in the other views.
>
> A tag question:
>
> You show the tags in alphabetic order, but the color used is for the top tag in the tag list.
>
> BTW, I have translated tag to flag (in Swedish flagga)
>
> /Peter
>
> ------------------------------------------------------------------------------
> Start uncovering the many advantages of virtual appliances
> and start using them to simplify application deployment and
> accelerate your shift to cloud computing.
> http://p.sf.net/sfu/novell-sfdev2dev
> _______________________________________________
> Gramps-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/gramps-devel
>
>
>

Helge@Gramps

Re: GEPS 011: Tagging update

In reply to this post by Nick Hall-6

Hi,

I like the idea of tagging as started now for people.
Because I did use markers in the past, here this my question: Did you think about / plan a helper function "add_TagIfNotYetAvailable " (or some thing like this) using filters (e.g. based on markers)? For my opinion such a function could be helpful to move from using markers today to use tags in the future.

-Helge

Benny Malengier

Re: GEPS 011: Tagging update

2010/9/22 Helge@Gramps <[hidden email]>

Hi,

I like the idea of tagging as started now for people.
Because I did use markers in the past, here this my question: Did you think
about / plan a helper function "add_TagIfNotYetAvailable " (or some thing
like this) using filters (e.g. based on markers)? For my opinion such a
function could be helpful to move from using markers today to use tags in
the future.

I would advocate to remove Markers before release, and upgrade them to tags, if no use case is present anymore for markers in 3.3
So, personally I don't use markers, so I will not miss them. Are there people who still need markers for something once tags are present?

If no developer has a reason, we ask same question on the user list.

Benny

-Helge

--
View this message in context: http://gramps.1791082.n4.nabble.com/GEPS-011-Tagging-update-tp2549199p2551074.html
Sent from the GRAMPS - Dev mailing list archive at Nabble.com.

------------------------------------------------------------------------------
Start uncovering the many advantages of virtual appliances
and start using them to simplify application deployment and
accelerate your shift to cloud computing.
http://p.sf.net/sfu/novell-sfdev2dev
_______________________________________________
Gramps-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gramps-devel

jerome

Re: GEPS 011: Tagging update

In reply to this post by Nick Hall-6

I have no problem, if my markers move to tags!
Note, also on Family and Note objects ?

MarkerReport will be a tag report and marker filter rules will be deprecated. Preferences dialog will set tag color instaed of marker color. DTD schema will be fixed (no more references about marker on all objects).

--- En date de : Jeu 23.9.10, Benny Malengier <[hidden email]> a écrit :

De: Benny Malengier <[hidden email]>
Objet: Re: [Gramps-devel] GEPS 011: Tagging update
À: "Helge@Gramps" <[hidden email]>
Cc: [hidden email]
Date: Jeudi 23 septembre 2010, 9h32

2010/9/22 Helge@Gramps <[hidden email]>

Hi,

I like the idea of tagging as started now for people.

Because I did use markers in the past, here this my question: Did you think

about / plan a helper function "add_TagIfNotYetAvailable " (or some thing

like this) using filters (e.g. based on markers)? For my opinion such a

function could be helpful to move from using markers today to use tags in

the future.

I would advocate to remove Markers before release, and upgrade them to tags, if no use case is present anymore for markers in 3.3
So, personally I don't use markers, so I will not miss them. Are there people who still need markers for something once tags are present?

If no developer has a reason, we ask same question on the user list.

Benny

-Helge

--

View this message in context: http://gramps.1791082.n4.nabble.com/GEPS-011-Tagging-update-tp2549199p2551074.html

Sent from the GRAMPS - Dev mailing list archive at Nabble.com.

------------------------------------------------------------------------------

Start uncovering the many advantages of virtual appliances

and start using them to simplify application deployment and

accelerate your shift to cloud computing.

http://p.sf.net/sfu/novell-sfdev2dev

_______________________________________________

Gramps-devel mailing list

[hidden email]

https://lists.sourceforge.net/lists/listinfo/gramps-devel

-----La pièce jointe associée suit-----

------------------------------------------------------------------------------
Start uncovering the many advantages of virtual appliances
and start using them to simplify application deployment and
accelerate your shift to cloud computing.
http://p.sf.net/sfu/novell-sfdev2dev
-----La pièce jointe associée suit-----

_______________________________________________
Gramps-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gramps-devel

------------------------------------------------------------------------------
Start uncovering the many advantages of virtual appliances
and start using them to simplify application deployment and
accelerate your shift to cloud computing.
http://p.sf.net/sfu/novell-sfdev2dev
_______________________________________________
Gramps-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gramps-devel

Nick Hall-6

Re: GEPS 011: Tagging update

jerome wrote:
> I have no problem, if my markers move to tags!
> Note, also on Family and Note objects ?
>

Good question. What objects do we want to tag?

Clearly, tagging people is the most useful application for tags.
Technically we can implement tagging for any of the primary objects. I
don't think that we should necessarily implement tagging for all primary
objects just because we can though. Perhaps we should think about the
use cases before deciding?

> MarkerReport will be a tag report and marker filter rules will be deprecated. Preferences dialog will set tag color instaed of marker color. DTD schema will be fixed (no more references about marker on all objects).
>

I will write a Tag Report anyway.

Tag colours are defined in the database using the Tag Organizer. I have
no plans to allow them to be configured from the Preferences dialog as
well. The rows in the person views are now coloured using the tag
colours rather than the marker colours.

Nick.

> --- En date de : Jeu 23.9.10, Benny Malengier <[hidden email]> a écrit :
>
> De: Benny Malengier <[hidden email]>
> Objet: Re: [Gramps-devel] GEPS 011: Tagging update
> À: "Helge@Gramps" <[hidden email]>
> Cc: [hidden email]
> Date: Jeudi 23 septembre 2010, 9h32
>
>
>
> 2010/9/22 Helge@Gramps <[hidden email]>
>
>
>
> Hi,
>
>
>
> I like the idea of tagging as started now for people.
>
> Because I did use markers in the past, here this my question: Did you think
>
> about / plan a helper function "add_TagIfNotYetAvailable " (or some thing
>
> like this) using filters (e.g. based on markers)? For my opinion such a
>
> function could be helpful to move from using markers today to use tags in
>
> the future.
>
> I would advocate to remove Markers before release, and upgrade them to tags, if no use case is present anymore for markers in 3.3
> So, personally I don't use markers, so I will not miss them. Are there people who still need markers for something once tags are present?
>
>
> If no developer has a reason, we ask same question on the user list.
>
> Benny
>
>
>
>
> -Helge
>
>
>
> --
>
> View this message in context: http://gramps.1791082.n4.nabble.com/GEPS-011-Tagging-update-tp2549199p2551074.html
>
>
> Sent from the GRAMPS - Dev mailing list archive at Nabble.com.
>
>
>
> ------------------------------------------------------------------------------
>
> Start uncovering the many advantages of virtual appliances
>
> and start using them to simplify application deployment and
>
> accelerate your shift to cloud computing.
>
> http://p.sf.net/sfu/novell-sfdev2dev
>
> _______________________________________________
>
> Gramps-devel mailing list
>
> [hidden email]
>
> https://lists.sourceforge.net/lists/listinfo/gramps-devel
>
>
>
>
> -----La pièce jointe associée suit-----
>
> ------------------------------------------------------------------------------
> Start uncovering the many advantages of virtual appliances
> and start using them to simplify application deployment and
> accelerate your shift to cloud computing.
> http://p.sf.net/sfu/novell-sfdev2dev
> -----La pièce jointe associée suit-----
>
> _______________________________________________
> Gramps-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/gramps-devel
>
>
>
>
>
> ------------------------------------------------------------------------------
> Start uncovering the many advantages of virtual appliances
> and start using them to simplify application deployment and
> accelerate your shift to cloud computing.
> http://p.sf.net/sfu/novell-sfdev2dev
> _______________________________________________
> Gramps-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/gramps-devel
>
>
>

jerome

Re: GEPS 011: Tagging update

A question: how to set tag on database on DB commit ?
I want to update your DB tool (attribute to tag).

Thanks.
Jérôme

--- En date de : Jeu 23.9.10, Nick Hall <[hidden email]> a écrit :

------------------------------------------------------------------------------
Nokia and AT&T present the 2010 Calling All Innovators-North America contest
Create new apps & games for the Nokia N8 for consumers in U.S. and Canada
$10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing
Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store
http://p.sf.net/sfu/nokia-dev2dev
_______________________________________________
Gramps-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gramps-devel

Nick Hall-6

Re: GEPS 011: Tagging update

Jerome,

You can do the same things with tags as you can with the other primary
objects.

The tag object itself has three properties that you are interested in:
name, color and priority. These have get and set methods as usual. Tag
priorities are integers starting from zero, you can initialise the
priority of a new tag with:

tag.set_priority(self.db.get_number_of_tags())

For a new tag you will want to set the name, but the color defaults to
black so there is no need to set it.

I'll email you an update for the tag conversion tool.

Nick.

jerome wrote:

> A question: how to set tag on database on DB commit ?
> I want to update your DB tool (attribute to tag).
>
> Thanks.
> Jérôme
>
> --- En date de : Jeu 23.9.10, Nick Hall <[hidden email]> a écrit :
>
>
>> De: Nick Hall <[hidden email]>
>> Objet: Re: [Gramps-devel] GEPS 011: Tagging update
>> À: "jerome" <[hidden email]>
>> Cc: "Helge@Gramps" <[hidden email]>, "Benny Malengier" <[hidden email]>, [hidden email]
>> Date: Jeudi 23 septembre 2010, 13h52
>>
>>
>> jerome wrote:
>>
>>> I have no problem, if my markers move to tags!
>>> Note, also on Family and Note objects ?
>>>
>>>
>> Good question. What objects do we want to tag?
>>
>> Clearly, tagging people is the most useful application for
>> tags.
>> Technically we can implement tagging for any of the primary
>> objects. I
>> don't think that we should necessarily implement tagging
>> for all primary
>> objects just because we can though. Perhaps we should
>> think about the
>> use cases before deciding?
>>
>>
>>> MarkerReport will be a tag report and marker filter
>>>
>> rules will be deprecated. Preferences dialog will set tag
>> color instaed of marker color. DTD schema will be fixed (no
>> more references about marker on all objects).
>>
>>>
>>>
>> I will write a Tag Report anyway.
>>
>> Tag colours are defined in the database using the Tag
>> Organizer. I have
>> no plans to allow them to be configured from the
>> Preferences dialog as
>> well. The rows in the person views are now coloured
>> using the tag
>> colours rather than the marker colours.
>>
>>
>> Nick.
>>
>>
>>> --- En date de : Jeu 23.9.10, Benny Malengier <[hidden email]>
>>>
>> a écrit :
>>
>>> De: Benny Malengier <[hidden email]>
>>> Objet: Re: [Gramps-devel] GEPS 011: Tagging update
>>> À: "Helge@Gramps" <[hidden email]>
>>> Cc: [hidden email]
>>> Date: Jeudi 23 septembre 2010, 9h32
>>>
>>>
>>>
>>> 2010/9/22 Helge@Gramps <[hidden email]>
>>>
>>>
>>>
>>> Hi,
>>>
>>>
>>>
>>> I like the idea of tagging as started now for people.
>>>
>>> Because I did use markers in the past, here this my
>>>
>> question: Did you think
>>
>>> about / plan a helper function
>>>
>> "add_TagIfNotYetAvailable " (or some thing
>>
>>> like this) using filters (e.g. based on markers)? For
>>>
>> my opinion such a
>>
>>> function could be helpful to move from using markers
>>>
>> today to use tags in
>>
>>> the future.
>>>
>>> I would advocate to remove Markers before release, and
>>>
>> upgrade them to tags, if no use case is present anymore for
>> markers in 3.3
>>
>>> So, personally I don't use markers, so I will not miss
>>>
>> them. Are there people who still need markers for something
>> once tags are present?
>>
>>> If no developer has a reason, we ask same question on
>>>
>> the user list.
>>
>>> Benny
>>>
>>>
>>>
>>>
>>> -Helge
>>>
>>>
>>>
>>> --
>>>
>>> View this message in context: http://gramps.1791082.n4.nabble.com/GEPS-011-Tagging-update-tp2549199p2551074.html
>>>
>>>
>>> Sent from the GRAMPS - Dev mailing list archive at
>>>
>> Nabble.com.
>>
>>>
>>>
>>>
>> ------------------------------------------------------------------------------
>>
>>> Start uncovering the many advantages of virtual
>>>
>> appliances
>>
>>> and start using them to simplify application
>>>
>> deployment and
>>
>>> accelerate your shift to cloud computing.
>>>
>>> http://p.sf.net/sfu/novell-sfdev2dev
>>>
>>> _______________________________________________
>>>
>>> Gramps-devel mailing list
>>>
>>> [hidden email]
>>>
>>> https://lists.sourceforge.net/lists/listinfo/gramps-devel
>>>
>>>
>>>
>>>
>>> -----La pièce jointe associée suit-----
>>>
>>>
>>>
>> ------------------------------------------------------------------------------
>>
>>> Start uncovering the many advantages of virtual
>>>
>> appliances
>>
>>> and start using them to simplify application
>>>
>> deployment and
>>
>>> accelerate your shift to cloud computing.
>>> http://p.sf.net/sfu/novell-sfdev2dev
>>> -----La pièce jointe associée suit-----
>>>
>>> _______________________________________________
>>> Gramps-devel mailing list
>>> [hidden email]
>>> https://lists.sourceforge.net/lists/listinfo/gramps-devel
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>> ------------------------------------------------------------------------------
>>
>>> Start uncovering the many advantages of virtual
>>>
>> appliances
>>
>>> and start using them to simplify application
>>>
>> deployment and
>>
>>> accelerate your shift to cloud computing.
>>> http://p.sf.net/sfu/novell-sfdev2dev
>>> _______________________________________________
>>> Gramps-devel mailing list
>>> [hidden email]
>>> https://lists.sourceforge.net/lists/listinfo/gramps-devel
>>>
>>>
>>>
>>>
>
>
>
>
>
>

jerome

Re: GEPS 011: Tagging update

Thank you Nick,

First step worked fine with your updated tool.
Now I have a lot of tags (5000 tags, 15 types)!
Playing with color, filter, remove action, etc ...no problem Great work!

Still sometimes the Gtk color warning on console
gui/utils.py:320: GtkWarning: Don't know color `'
gtk.main_iteration()
QuestionDialog.py:136: GtkWarning: Don't know color `'
response = self.top.run()
but no crash or error.

Maybe just a cosmetic issue.
Is there a way for adding a space after comma on tag list ? (PersonEditor) ?
I looked at gen/lib/tagbase.py
I suppose it is not safe because list should not have a space ?
I tought on someting like tag_list = ', '.join(tag_list) but I cannot see where to only modify the tag_list just for being displayed on PersonEditor!

There is a limitation: we cannot rename the tag.
But it should be possible to rename it into a Gramps XML file.

Regards,
Jérôme

--- En date de : Ven 24.9.10, Nick Hall <[hidden email]> a écrit :

> De: Nick Hall <[hidden email]>
> Objet: Re: [Gramps-devel] GEPS 011: Tagging update
> À: "jerome" <[hidden email]>
> Cc: "Helge@Gramps" <[hidden email]>, "Benny Malengier" <[hidden email]>, [hidden email]
> Date: Vendredi 24 septembre 2010, 18h57
> Jerome,
>
> You can do the same things with tags as you can with the
> other primary objects.
>
> The tag object itself has three properties that you are
> interested in: name, color and priority. These
> have get and set methods as usual. Tag priorities are
> integers starting from zero, you can initialise the priority
> of a new tag with:
>
> tag.set_priority(self.db.get_number_of_tags())
>
> For a new tag you will want to set the name, but the color
> defaults to black so there is no need to set it.
>
> I'll email you an update for the tag conversion tool.
>
> Nick.
>
>
> jerome wrote:
> > A question: how to set tag on database on DB commit ?
> > I want to update your DB tool (attribute to tag).
> >
> > Thanks.
> > Jérôme
> >
> > --- En date de : Jeu 23.9.10, Nick Hall <[hidden email]>
> a écrit :
> >
> >
> >> De: Nick Hall <[hidden email]>
> >> Objet: Re: [Gramps-devel] GEPS 011: Tagging
> update
> >> À: "jerome" <[hidden email]>
> >> Cc: "Helge@Gramps" <[hidden email]>,
> "Benny Malengier" <[hidden email]>,
> [hidden email]
> >> Date: Jeudi 23 septembre 2010, 13h52
> >>
> >>
> >> jerome wrote:
> >>
> >>> I have no problem, if my markers move to
> tags!
> >>> Note, also on Family and Note objects ?
> >>>
> >> Good question. What objects do we want to
> tag?
> >>
> >> Clearly, tagging people is the most useful
> application for
> >> tags. Technically we can implement tagging
> for any of the primary
> >> objects. I don't think that we should
> necessarily implement tagging
> >> for all primary objects just because we can
> though. Perhaps we should
> >> think about the use cases before deciding?
> >>
> >>
> >>> MarkerReport will be a tag report and marker
> filter
> >>>
> >> rules will be deprecated. Preferences dialog will
> set tag
> >> color instaed of marker color. DTD schema will be
> fixed (no
> >> more references about marker on all objects).
> >>
> >>>
> >> I will write a Tag Report anyway.
> >>
> >> Tag colours are defined in the database using the
> Tag
> >> Organizer. I have no plans to allow them to
> be configured from the
> >> Preferences dialog as well. The rows in the
> person views are now coloured
> >> using the tag colours rather than the marker
> colours.
> >>
> >>
> >> Nick.
> >>
> >>
> >>> --- En date de : Jeu 23.9.10, Benny Malengier
> <[hidden email]>
> >>>
> >> a écrit :
> >>
> >>> De: Benny Malengier <[hidden email]>
> >>> Objet: Re: [Gramps-devel] GEPS 011: Tagging
> update
> >>> À: "Helge@Gramps" <[hidden email]>
> >>> Cc: [hidden email]
> >>> Date: Jeudi 23 septembre 2010, 9h32
> >>>
> >>>
> >>>
> >>> 2010/9/22 Helge@Gramps <[hidden email]>
> >>>
> >>>
> >>>
> >>> Hi,
> >>>
> >>>
> >>>
> >>> I like the idea of tagging as started now for
> people.
> >>>
> >>> Because I did use markers in the past, here
> this my
> >>>
> >> question: Did you think
> >>
> >>> about / plan a helper function
> >>>
> >> "add_TagIfNotYetAvailable " (or some thing
> >>
> >>> like this) using filters (e.g. based on
> markers)? For
> >>>
> >> my opinion such a
> >>
> >>> function could be helpful to move from using
> markers
> >>>
> >> today to use tags in
> >>
> >>> the future.
> >>>
> >>> I would advocate to remove Markers before
> release, and
> >>>
> >> upgrade them to tags, if no use case is present
> anymore for
> >> markers in 3.3
> >>> So, personally I don't use markers, so I will
> not miss
> >>>
> >> them. Are there people who still need markers for
> something
> >> once tags are present?
> >>
> >>> If no developer has a reason, we ask same
> question on
> >>>
> >> the user list.
> >>
> >>> Benny
> >>>
> >>>
> >>>
> >>> -Helge
> >>>
> >>>
> >>>
> >>> --
> >>>
> >>> View this message in context: http://gramps.1791082.n4.nabble.com/GEPS-011-Tagging-update-tp2549199p2551074.html
> >>>
> >>>
> >>> Sent from the GRAMPS - Dev mailing list
> archive at
> >>>
> >> Nabble.com.
> >>
> >>>
> >>>
> >>>
> >>
> ------------------------------------------------------------------------------
> >>
> >>> Start uncovering the many advantages of
> virtual
> >>>
> >> appliances
> >>
> >>> and start using them to simplify application
> >>>
> >> deployment and
> >>
> >>> accelerate your shift to cloud computing.
> >>>
> >>> http://p.sf.net/sfu/novell-sfdev2dev
> >>>
> >>>
> _______________________________________________
> >>>
> >>> Gramps-devel mailing list
> >>>
> >>> [hidden email]
> >>>
> >>> https://lists.sourceforge.net/lists/listinfo/gramps-devel
> >>>
> >>>
> >>>
> >>>
> >>> -----La pièce jointe associée suit-----
> >>>
> >>>
> >>>
> >>
> ------------------------------------------------------------------------------
> >>
> >>> Start uncovering the many advantages of
> virtual
> >>>
> >> appliances
> >>
> >>> and start using them to simplify application
> >>>
> >> deployment and
> >>
> >>> accelerate your shift to cloud computing.
> >>> http://p.sf.net/sfu/novell-sfdev2dev
> >>> -----La pièce jointe associée suit-----
> >>>
> >>>
> _______________________________________________
> >>> Gramps-devel mailing list
> >>> [hidden email]
> >>> https://lists.sourceforge.net/lists/listinfo/gramps-devel
> >>>
> >>>
> >>>
> >>>
> >>>
> >>>
> >>
> ------------------------------------------------------------------------------
> >>
> >>> Start uncovering the many advantages of
> virtual
> >>>
> >> appliances
> >>
> >>> and start using them to simplify application
> >>>
> >> deployment and
> >>
> >>> accelerate your shift to cloud computing.
> >>> http://p.sf.net/sfu/novell-sfdev2dev
> >>>
> _______________________________________________
> >>> Gramps-devel mailing list
> >>> [hidden email]
> >>> https://lists.sourceforge.net/lists/listinfo/gramps-devel
> >>>
> >>>
> >>>
> >
> >
> >
> >
> >

Nick Hall-6

Re: GEPS 011: Tagging update

jerome wrote:
> Thank you Nick,
>
> First step worked fine with your updated tool.
> Now I have a lot of tags (5000 tags, 15 types)!
> Playing with color, filter, remove action, etc ...no problem Great work!
>

Thanks.

> Still sometimes the Gtk color warning on console
> gui/utils.py:320: GtkWarning: Don't know color `'
> gtk.main_iteration()
> QuestionDialog.py:136: GtkWarning: Don't know color `'
> response = self.top.run()
> but no crash or error.
>
>

I am aware of this - http://www.gramps-project.org/bugs/view.php?id=1937

I'll look at it when I have time. It shouldn't cause a problem.

> Maybe just a cosmetic issue.
> Is there a way for adding a space after comma on tag list ? (PersonEditor) ?
> I looked at gen/lib/tagbase.py
> I suppose it is not safe because list should not have a space ?
> I tought on someting like tag_list = ', '.join(tag_list) but I cannot see where to only modify the tag_list just for being displayed on PersonEditor!
>
>

It is just a cosmetic issue, but I think you are right that it would
look better with a space.

I have added the space in r15927.

> There is a limitation: we cannot rename the tag.
>

Yes, this is on my To-Do list. I also plan to add tags to the context
menus in the views.

> But it should be possible to rename it into a Gramps XML file.
>
>

I am working on the export and import at the moment. Until it is
complete, to rename a tag you will have to create a new one as follows:

1. Filter on the tag you want to rename.
2. Select all rows with Ctrl-A.
3. Tag the rows with a new tag name.
4. Delete the old tag.

Regards,

Nick.

> Regards,
> Jérôme
>
>
>
> --- En date de : Ven 24.9.10, Nick Hall <[hidden email]> a écrit :
>
>
>> De: Nick Hall <[hidden email]>
>> Objet: Re: [Gramps-devel] GEPS 011: Tagging update
>> À: "jerome" <[hidden email]>
>> Cc: "Helge@Gramps" <[hidden email]>, "Benny Malengier" <[hidden email]>, [hidden email]
>> Date: Vendredi 24 septembre 2010, 18h57
>> Jerome,
>>
>> You can do the same things with tags as you can with the
>> other primary objects.
>>
>> The tag object itself has three properties that you are
>> interested in: name, color and priority. These
>> have get and set methods as usual. Tag priorities are
>> integers starting from zero, you can initialise the priority
>> of a new tag with:
>>
>> tag.set_priority(self.db.get_number_of_tags())
>>
>> For a new tag you will want to set the name, but the color
>> defaults to black so there is no need to set it.
>>
>> I'll email you an update for the tag conversion tool.
>>
>> Nick.
>>
>>
>> jerome wrote:
>>
>>> A question: how to set tag on database on DB commit ?
>>> I want to update your DB tool (attribute to tag).
>>>
>>> Thanks.
>>> Jérôme
>>>
>>> --- En date de : Jeu 23.9.10, Nick Hall <[hidden email]>
>>>
>> a écrit :
>>
>>>
>>>
>>>> De: Nick Hall <[hidden email]>
>>>> Objet: Re: [Gramps-devel] GEPS 011: Tagging
>>>>
>> update
>>
>>>> À: "jerome" <[hidden email]>
>>>> Cc: "Helge@Gramps" <[hidden email]>,
>>>>
>> "Benny Malengier" <[hidden email]>,
>> [hidden email]
>>
>>>> Date: Jeudi 23 septembre 2010, 13h52
>>>>
>>>>
>>>> jerome wrote:
>>>>
>>>>
>>>>> I have no problem, if my markers move to
>>>>>
>> tags!
>>
>>>>> Note, also on Family and Note objects ?
>>>>>
>>>>>
>>>> Good question. What objects do we want to
>>>>
>> tag?
>>
>>>> Clearly, tagging people is the most useful
>>>>
>> application for
>>
>>>> tags. Technically we can implement tagging
>>>>
>> for any of the primary
>>
>>>> objects. I don't think that we should
>>>>
>> necessarily implement tagging
>>
>>>> for all primary objects just because we can
>>>>
>> though. Perhaps we should
>>
>>>> think about the use cases before deciding?
>>>>
>>>>
>>>>
>>>>> MarkerReport will be a tag report and marker
>>>>>
>> filter
>>
>>>>>
>>>>>
>>>> rules will be deprecated. Preferences dialog will
>>>>
>> set tag
>>
>>>> color instaed of marker color. DTD schema will be
>>>>
>> fixed (no
>>
>>>> more references about marker on all objects).
>>>>
>>>>
>>>>>
>>>>>
>>>> I will write a Tag Report anyway.
>>>>
>>>> Tag colours are defined in the database using the
>>>>
>> Tag
>>
>>>> Organizer. I have no plans to allow them to
>>>>
>> be configured from the
>>
>>>> Preferences dialog as well. The rows in the
>>>>
>> person views are now coloured
>>
>>>> using the tag colours rather than the marker
>>>>
>> colours.
>>
>>>> Nick.
>>>>
>>>>
>>>>
>>>>> --- En date de : Jeu 23.9.10, Benny Malengier
>>>>>
>> <[hidden email]>
>>
>>>>>
>>>>>
>>>> a écrit :
>>>>
>>>>
>>>>> De: Benny Malengier <[hidden email]>
>>>>> Objet: Re: [Gramps-devel] GEPS 011: Tagging
>>>>>
>> update
>>
>>>>> À: "Helge@Gramps" <[hidden email]>
>>>>> Cc: [hidden email]
>>>>> Date: Jeudi 23 septembre 2010, 9h32
>>>>>
>>>>>
>>>>>
>>>>> 2010/9/22 Helge@Gramps <[hidden email]>
>>>>>
>>>>>
>>>>>
>>>>> Hi,
>>>>>
>>>>>
>>>>>
>>>>> I like the idea of tagging as started now for
>>>>>
>> people.
>>
>>>>> Because I did use markers in the past, here
>>>>>
>> this my
>>
>>>>>
>>>>>
>>>> question: Did you think
>>>>
>>>>
>>>>> about / plan a helper function
>>>>>
>>>>>
>>>> "add_TagIfNotYetAvailable " (or some thing
>>>>
>>>>
>>>>> like this) using filters (e.g. based on
>>>>>
>> markers)? For
>>
>>>>>
>>>>>
>>>> my opinion such a
>>>>
>>>>
>>>>> function could be helpful to move from using
>>>>>
>> markers
>>
>>>>>
>>>>>
>>>> today to use tags in
>>>>
>>>>
>>>>> the future.
>>>>>
>>>>> I would advocate to remove Markers before
>>>>>
>> release, and
>>
>>>>>
>>>>>
>>>> upgrade them to tags, if no use case is present
>>>>
>> anymore for
>>
>>>> markers in 3.3
>>>>
>>>>> So, personally I don't use markers, so I will
>>>>>
>> not miss
>>
>>>>>
>>>>>
>>>> them. Are there people who still need markers for
>>>>
>> something
>>
>>>> once tags are present?
>>>>
>>>>
>>>>> If no developer has a reason, we ask same
>>>>>
>> question on
>>
>>>>>
>>>>>
>>>> the user list.
>>>>
>>>>
>>>>> Benny
>>>>>
>>>>>
>>>>>
>>>>> -Helge
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>>
>>>>> View this message in context: http://gramps.1791082.n4.nabble.com/GEPS-011-Tagging-update-tp2549199p2551074.html
>>>>>
>>>>>
>>>>> Sent from the GRAMPS - Dev mailing list
>>>>>
>> archive at
>>
>>>>>
>>>>>
>>>> Nabble.com.
>>>>
>>>>
>>>>>
>>>>>
>> ------------------------------------------------------------------------------
>>
>>>>
>>>>
>>>>> Start uncovering the many advantages of
>>>>>
>> virtual
>>
>>>>>
>>>>>
>>>> appliances
>>>>
>>>>
>>>>> and start using them to simplify application
>>>>>
>>>>>
>>>> deployment and
>>>>
>>>>
>>>>> accelerate your shift to cloud computing.
>>>>>
>>>>> http://p.sf.net/sfu/novell-sfdev2dev
>>>>>
>>>>>
>>>>>
>> _______________________________________________
>>
>>>>> Gramps-devel mailing list
>>>>>
>>>>> [hidden email]
>>>>>
>>>>> https://lists.sourceforge.net/lists/listinfo/gramps-devel
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> -----La pièce jointe associée suit-----
>>>>>
>>>>>
>>>>>
>>>>>
>> ------------------------------------------------------------------------------
>>
>>>>
>>>>
>>>>> Start uncovering the many advantages of
>>>>>
>> virtual
>>
>>>>>
>>>>>
>>>> appliances
>>>>
>>>>
>>>>> and start using them to simplify application
>>>>>
>>>>>
>>>> deployment and
>>>>
>>>>
>>>>> accelerate your shift to cloud computing.
>>>>> http://p.sf.net/sfu/novell-sfdev2dev
>>>>> -----La pièce jointe associée suit-----
>>>>>
>>>>>
>>>>>
>> _______________________________________________
>>
>>>>> Gramps-devel mailing list
>>>>> [hidden email]
>>>>> https://lists.sourceforge.net/lists/listinfo/gramps-devel
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>> ------------------------------------------------------------------------------
>>
>>>>
>>>>
>>>>> Start uncovering the many advantages of
>>>>>
>> virtual
>>
>>>>>
>>>>>
>>>> appliances
>>>>
>>>>
>>>>> and start using them to simplify application
>>>>>
>>>>>
>>>> deployment and
>>>>
>>>>
>>>>> accelerate your shift to cloud computing.
>>>>> http://p.sf.net/sfu/novell-sfdev2dev
>>>>>
>>>>>
>> _______________________________________________
>>
>>>>> Gramps-devel mailing list
>>>>> [hidden email]
>>>>> https://lists.sourceforge.net/lists/listinfo/gramps-devel
>>>>>
>>>>>
>>>>>
>>>>>
>>>
>>>
>>>
>>>
>
>
>
>
>
>

jerome

GEPS 011: Tagging update

> I am working on the export and import at the moment.
> Until it is complete, to rename a tag you will have to
> create a new one as follows:
>
> 1. Filter on the tag you want to rename.
> 2. Select all rows with Ctrl-A.
> 3. Tag the rows with a new tag name.
> 4. Delete the old tag.

oh, that's clever!

> I have added the space in r15927.

Thanks!
Yes, it was more logical, code was on treemodel and widgets.

> I am aware of this - http://www.gramps-project.org/bugs/view.php?id=1937
>
> I'll look at it when I have time. It shouldn't cause
> a problem.

Yes, I was the reporter ... two years ago!
That's not a big problem, just a warning.

Note last year, I thought it could be closed!
2009-01-16 09:53 romjerome Status new => closed
2009-01-16 09:53 romjerome Resolution open => unable to reproduce
But I let it open if we will be able to reproduce it.

> Yes, this is on my To-Do list. I also plan to add
> tags to the context menus in the views.

no problem.
I just listed my first impressions.
Also for import/export, there is no deadline.

Jérôme

--- En date de : Ven 24.9.10, Nick Hall <[hidden email]> a écrit :

> De: Nick Hall <[hidden email]>
> Objet: Re: [Gramps-devel] GEPS 011: Tagging update
> À: "jerome" <[hidden email]>
> Cc: "Helge@Gramps" <[hidden email]>, "Benny Malengier" <[hidden email]>, [hidden email]
> Date: Vendredi 24 septembre 2010, 22h41
>
>
> jerome wrote:
> > Thank you Nick,
> >
> > First step worked fine with your updated tool.
> > Now I have a lot of tags (5000 tags, 15 types)!
> > Playing with color, filter, remove action, etc ...no
> problem Great work!
> >
>
> Thanks.
>
> > Still sometimes the Gtk color warning on console
> gui/utils.py:320: GtkWarning: Don't know color `'
> >   gtk.main_iteration()
> > QuestionDialog.py:136: GtkWarning: Don't know color
> `'
> >   response = self.top.run()
> > but no crash or error.
> >
> >
>
> I am aware of this - http://www.gramps-project.org/bugs/view.php?id=1937
>
> I'll look at it when I have time. It shouldn't cause
> a problem.
>
> > Maybe just a cosmetic issue.
> > Is there a way for adding a space after comma on tag
> list ? (PersonEditor) ?
> > I looked at gen/lib/tagbase.py
> > I suppose it is not safe because list should not have
> a space ?
> > I tought on someting like tag_list = ',
> '.join(tag_list) but I cannot see where to only modify the
> tag_list just for being displayed on PersonEditor!
> >
> >
>
> It is just a cosmetic issue, but I think you are right that
> it would look better with a space.
>
> I have added the space in r15927.
>
> > There is a limitation: we cannot rename the tag.
> >
>
> Yes, this is on my To-Do list. I also plan to add
> tags to the context menus in the views.
>
> > But it should be possible to rename it into a Gramps
> XML file.
> >
> >
>
> I am working on the export and import at the moment.
> Until it is complete, to rename a tag you will have to
> create a new one as follows:
>
> 1. Filter on the tag you want to rename.
> 2. Select all rows with Ctrl-A.
> 3. Tag the rows with a new tag name.
> 4. Delete the old tag.
>
>
> Regards,
>
>
> Nick.
>
> > Regards,
> > Jérôme
> >
> >
> >
> > --- En date de : Ven 24.9.10, Nick Hall <[hidden email]>
> a écrit :
> >
> >
> >> De: Nick Hall <[hidden email]>
> >> Objet: Re: [Gramps-devel] GEPS 011: Tagging
> update
> >> À: "jerome" <[hidden email]>
> >> Cc: "Helge@Gramps" <[hidden email]>,
> "Benny Malengier" <[hidden email]>,
> [hidden email]
> >> Date: Vendredi 24 septembre 2010, 18h57
> >> Jerome,
> >>
> >> You can do the same things with tags as you can
> with the
> >> other primary objects.
> >>
> >> The tag object itself has three properties that
> you are
> >> interested in: name, color and
> priority. These
> >> have get and set methods as usual. Tag
> priorities are
> >> integers starting from zero, you can initialise
> the priority
> >> of a new tag with:
> >>
> >> tag.set_priority(self.db.get_number_of_tags())
> >>
> >> For a new tag you will want to set the name, but
> the color
> >> defaults to black so there is no need to set it.
> >>
> >> I'll email you an update for the tag conversion
> tool.
> >>
> >> Nick.
> >>
> >>
> >> jerome wrote:
> >>
> >>> A question: how to set tag on database on DB
> commit ?
> >>> I want to update your DB tool (attribute to
> tag).
> >>>
> >>> Thanks.
> >>> Jérôme
> >>>
> >>> --- En date de : Jeu 23.9.10, Nick Hall <[hidden email]>
> >>>
> >> a écrit :
> >>
> >>>
> >>>> De: Nick Hall <[hidden email]>
> >>>> Objet: Re: [Gramps-devel] GEPS 011:
> Tagging
> >>>>
> >> update
> >>
> >>>> À: "jerome" <[hidden email]>
> >>>> Cc: "Helge@Gramps" <[hidden email]>,
> >>>>
> >> "Benny Malengier" <[hidden email]>,
> >> [hidden email]
> >>
> >>>> Date: Jeudi 23 septembre 2010, 13h52
> >>>>
> >>>>
> >>>> jerome wrote:
> >>>>
>
> >>>>> I have no problem, if my markers move
> to
> >>>>>
>
> >> tags!
> >>
> >>>>> Note, also on Family and Note objects
> ?
> >>>>>
>
> >>>> Good question. What objects do we
> want to
> >>>>
> >> tag?
> >>
> >>>> Clearly, tagging people is the most
> useful
> >>>>
> >> application for
> >>
> >>>> tags. Technically we can implement
> tagging
> >>>>
> >> for any of the primary
> >>
> >>>> objects. I don't think that we
> should
> >>>>
> >> necessarily implement tagging
> >>
> >>>> for all primary objects just because we
> can
> >>>>
> >> though. Perhaps we should
> >>
> >>>> think about the use cases before
> deciding?
> >>>>
> >>>>
>
> >>>>> MarkerReport will be a tag report and
> marker
> >>>>>
>
> >> filter
> >>
> >>>>>
>
> >>>> rules will be deprecated. Preferences
> dialog will
> >>>>
> >> set tag
> >>
> >>>> color instaed of marker color. DTD schema
> will be
> >>>>
> >> fixed (no
> >>
> >>>> more references about marker on all
> objects).
> >>>>
>
> >>>>>
>
> >>>> I will write a Tag Report anyway.
> >>>>
> >>>> Tag colours are defined in the database
> using the
> >>>>
> >> Tag
> >>
> >>>> Organizer. I have no plans to allow
> them to
> >>>>
> >> be configured from the
> >>
> >>>> Preferences dialog as well. The rows
> in the
> >>>>
> >> person views are now coloured
> >>
> >>>> using the tag colours rather than the
> marker
> >>>>
> >> colours.
> >>
> >>>> Nick.
> >>>>
> >>>>
>
> >>>>> --- En date de : Jeu 23.9.10, Benny
> Malengier
> >>>>>
>
> >> <[hidden email]>
> >>
> >>>>>
>
> >>>> a écrit :
> >>>>
>
> >>>>> De: Benny Malengier <[hidden email]>
> >>>>> Objet: Re: [Gramps-devel] GEPS 011:
> Tagging
> >>>>>
>
> >> update
> >>
> >>>>> À: "Helge@Gramps" <[hidden email]>
> >>>>> Cc: [hidden email]
> >>>>> Date: Jeudi 23 septembre 2010, 9h32
> >>>>>
> >>>>>
> >>>>>
> >>>>> 2010/9/22 Helge@Gramps <[hidden email]>
> >>>>>
> >>>>>
> >>>>>
> >>>>> Hi,
> >>>>>
> >>>>>
> >>>>>
> >>>>> I like the idea of tagging as started
> now for
> >>>>>
>
> >> people.
> >>
> >>>>> Because I did use markers in the past,
> here
> >>>>>
>
> >> this my
> >>
> >>>>>
>
> >>>> question: Did you think
> >>>>
>
> >>>>> about / plan a helper function
> >>>>>
>
> >>>> "add_TagIfNotYetAvailable " (or some
> thing
> >>>>
>
> >>>>> like this) using filters (e.g. based
> on
> >>>>>
>
> >> markers)? For
> >>
> >>>>>
>
> >>>> my opinion such a
> >>>>
>
> >>>>> function could be helpful to move from
> using
> >>>>>
>
> >> markers
> >>
> >>>>>
>
> >>>> today to use tags in
> >>>>
>
> >>>>> the future.
> >>>>>
> >>>>> I would advocate to remove Markers
> before
> >>>>>
>
> >> release, and
> >>
> >>>>>
>
> >>>> upgrade them to tags, if no use case is
> present
> >>>>
> >> anymore for
> >>
> >>>> markers in 3.3
>
> >>>>> So, personally I don't use markers, so
> I will
> >>>>>
>
> >> not miss
> >>
> >>>>>
>
> >>>> them. Are there people who still need
> markers for
> >>>>
> >> something
> >>
> >>>> once tags are present?
> >>>>
>
> >>>>> If no developer has a reason, we ask
> same
> >>>>>
>
> >> question on
> >>
> >>>>>
>
> >>>> the user list.
> >>>>
>
> >>>>> Benny
> >>>>>
> >>>>>
> >>>>> -Helge
> >>>>>
> >>>>>
> >>>>>
> >>>>> --
> >>>>>
> >>>>> View this message in context: http://gramps.1791082.n4.nabble.com/GEPS-011-Tagging-update-tp2549199p2551074.html
> >>>>>
> >>>>>
> >>>>> Sent from the GRAMPS - Dev mailing
> list
> >>>>>
>
> >> archive at
> >>
> >>>>>
>
> >>>> Nabble.com.
> >>>>
>
> >>>>>
>
> >>
> ------------------------------------------------------------------------------
> >>
> >>>>
>
> >>>>> Start uncovering the many advantages
> of
> >>>>>
>
> >> virtual
> >>
> >>>>>
>
> >>>> appliances
> >>>>
>
> >>>>> and start using them to simplify
> application
> >>>>>
>
> >>>> deployment and
> >>>>
>
> >>>>> accelerate your shift to cloud
> computing.
> >>>>>
> >>>>> http://p.sf.net/sfu/novell-sfdev2dev
> >>>>>
> >>>>>
> >>>>>
>
> >> _______________________________________________
> >>
> >>>>> Gramps-devel mailing list
> >>>>>
> >>>>> [hidden email]
> >>>>>
> >>>>> https://lists.sourceforge.net/lists/listinfo/gramps-devel
> >>>>>
> >>>>>
> >>>>>
> >>>>>
> >>>>> -----La pièce jointe associée
> suit-----
> >>>>>
> >>>>>
> >>>>>
>
> >>
> ------------------------------------------------------------------------------
> >>
> >>>>
>
> >>>>> Start uncovering the many advantages
> of
> >>>>>
>
> >> virtual
> >>
> >>>>>
>
> >>>> appliances
> >>>>
>
> >>>>> and start using them to simplify
> application
> >>>>>
>
> >>>> deployment and
> >>>>
>
> >>>>> accelerate your shift to cloud
> computing.
> >>>>> http://p.sf.net/sfu/novell-sfdev2dev
> >>>>> -----La pièce jointe associée
> suit-----
> >>>>>
> >>>>>
> >>>>>
>
> >> _______________________________________________
> >>
> >>>>> Gramps-devel mailing list
> >>>>> [hidden email]
> >>>>> https://lists.sourceforge.net/lists/listinfo/gramps-devel
> >>>>>
> >>>>>
> >>>>>
> >>>>>
>
> >>>>>
>
> >>
> ------------------------------------------------------------------------------
> >>
> >>>>
>
> >>>>> Start uncovering the many advantages
> of
> >>>>>
>
> >> virtual
> >>
> >>>>>
>
> >>>> appliances
> >>>>
>
> >>>>> and start using them to simplify
> application
> >>>>>
>
> >>>> deployment and
> >>>>
>
> >>>>> accelerate your shift to cloud
> computing.
> >>>>> http://p.sf.net/sfu/novell-sfdev2dev
> >>>>>
> >>>>>
>
> >> _______________________________________________
> >>
> >>>>> Gramps-devel mailing list
> >>>>> [hidden email]
> >>>>> https://lists.sourceforge.net/lists/listinfo/gramps-devel
> >>>>>
> >>>>>
> >>>>>
>
> >>>
> >>>
> >
> >
> >
> >
> >

jerome

Re: GEPS 011: Tagging update

In reply to this post by Nick Hall-6

> Until it is complete, to rename a tag you will have to
> create a new one as follows:
>
> 1. Filter on the tag you want to rename.
> 2. Select all rows with Ctrl-A.
> 3. Tag the rows with a new tag name.
> 4. Delete the old tag.

Something goes wrong with current ProgressMonitor use on gui/views/tags.py

The progress bar displays 100% but did not commit all transactions! I made 1298 changes at once (add/remove tags).

OK, '100% of selected handles' but not for the process...
Same problem for "Removing Tags"

I really get better performances by using ProgressMonitor after starting transactions.

- pmon.add_op(status)
trans = self.db.transaction_begin()
+ pmon.add_op(status)

Jérôme

--- En date de : Ven 24.9.10, Nick Hall <[hidden email]> a écrit :

> De: Nick Hall <[hidden email]>
> Objet: Re: [Gramps-devel] GEPS 011: Tagging update
> À: "jerome" <[hidden email]>
> Cc: "Helge@Gramps" <[hidden email]>, "Benny Malengier" <[hidden email]>, [hidden email]
> Date: Vendredi 24 septembre 2010, 22h41
>
>
> jerome wrote:
> > Thank you Nick,
> >
> > First step worked fine with your updated tool.
> > Now I have a lot of tags (5000 tags, 15 types)!
> > Playing with color, filter, remove action, etc ...no
> problem Great work!
> >
>
> Thanks.
>
> > Still sometimes the Gtk color warning on console
> gui/utils.py:320: GtkWarning: Don't know color `'
> >   gtk.main_iteration()
> > QuestionDialog.py:136: GtkWarning: Don't know color
> `'
> >   response = self.top.run()
> > but no crash or error.
> >
> >
>
> I am aware of this - http://www.gramps-project.org/bugs/view.php?id=1937
>
> I'll look at it when I have time. It shouldn't cause
> a problem.
>
> > Maybe just a cosmetic issue.
> > Is there a way for adding a space after comma on tag
> list ? (PersonEditor) ?
> > I looked at gen/lib/tagbase.py
> > I suppose it is not safe because list should not have
> a space ?
> > I tought on someting like tag_list = ',
> '.join(tag_list) but I cannot see where to only modify the
> tag_list just for being displayed on PersonEditor!
> >
> >
>
> It is just a cosmetic issue, but I think you are right that
> it would look better with a space.
>
> I have added the space in r15927.
>
> > There is a limitation: we cannot rename the tag.
> >
>
> Yes, this is on my To-Do list. I also plan to add
> tags to the context menus in the views.
>
> > But it should be possible to rename it into a Gramps
> XML file.
> >
> >
>
> I am working on the export and import at the moment.
> Until it is complete, to rename a tag you will have to
> create a new one as follows:
>
> 1. Filter on the tag you want to rename.
> 2. Select all rows with Ctrl-A.
> 3. Tag the rows with a new tag name.
> 4. Delete the old tag.
>
>
> Regards,
>
>
> Nick.
>
> > Regards,
> > Jérôme
> >
> >
> >
> > --- En date de : Ven 24.9.10, Nick Hall <[hidden email]>
> a écrit :
> >
> >
> >> De: Nick Hall <[hidden email]>
> >> Objet: Re: [Gramps-devel] GEPS 011: Tagging
> update
> >> À: "jerome" <[hidden email]>
> >> Cc: "Helge@Gramps" <[hidden email]>,
> "Benny Malengier" <[hidden email]>,
> [hidden email]
> >> Date: Vendredi 24 septembre 2010, 18h57
> >> Jerome,
> >>
> >> You can do the same things with tags as you can
> with the
> >> other primary objects.
> >>
> >> The tag object itself has three properties that
> you are
> >> interested in: name, color and
> priority. These
> >> have get and set methods as usual. Tag
> priorities are
> >> integers starting from zero, you can initialise
> the priority
> >> of a new tag with:
> >>
> >> tag.set_priority(self.db.get_number_of_tags())
> >>
> >> For a new tag you will want to set the name, but
> the color
> >> defaults to black so there is no need to set it.
> >>
> >> I'll email you an update for the tag conversion
> tool.
> >>
> >> Nick.
> >>
> >>
> >> jerome wrote:
> >>
> >>> A question: how to set tag on database on DB
> commit ?
> >>> I want to update your DB tool (attribute to
> tag).
> >>>
> >>> Thanks.
> >>> Jérôme
> >>>
> >>> --- En date de : Jeu 23.9.10, Nick Hall <[hidden email]>
> >>>
> >> a écrit :
> >>
> >>>
> >>>> De: Nick Hall <[hidden email]>
> >>>> Objet: Re: [Gramps-devel] GEPS 011:
> Tagging
> >>>>
> >> update
> >>
> >>>> À: "jerome" <[hidden email]>
> >>>> Cc: "Helge@Gramps" <[hidden email]>,
> >>>>
> >> "Benny Malengier" <[hidden email]>,
> >> [hidden email]
> >>
> >>>> Date: Jeudi 23 septembre 2010, 13h52
> >>>>
> >>>>
> >>>> jerome wrote:
> >>>>
>
> >>>>> I have no problem, if my markers move
> to
> >>>>>
>
> >> tags!
> >>
> >>>>> Note, also on Family and Note objects
> ?
> >>>>>
>
> >>>> Good question. What objects do we
> want to
> >>>>
> >> tag?
> >>
> >>>> Clearly, tagging people is the most
> useful
> >>>>
> >> application for
> >>
> >>>> tags. Technically we can implement
> tagging
> >>>>
> >> for any of the primary
> >>
> >>>> objects. I don't think that we
> should
> >>>>
> >> necessarily implement tagging
> >>
> >>>> for all primary objects just because we
> can
> >>>>
> >> though. Perhaps we should
> >>
> >>>> think about the use cases before
> deciding?
> >>>>
> >>>>
>
> >>>>> MarkerReport will be a tag report and
> marker
> >>>>>
>
> >> filter
> >>
> >>>>>
>
> >>>> rules will be deprecated. Preferences
> dialog will
> >>>>
> >> set tag
> >>
> >>>> color instaed of marker color. DTD schema
> will be
> >>>>
> >> fixed (no
> >>
> >>>> more references about marker on all
> objects).
> >>>>
>
> >>>>>
>
> >>>> I will write a Tag Report anyway.
> >>>>
> >>>> Tag colours are defined in the database
> using the
> >>>>
> >> Tag
> >>
> >>>> Organizer. I have no plans to allow
> them to
> >>>>
> >> be configured from the
> >>
> >>>> Preferences dialog as well. The rows
> in the
> >>>>
> >> person views are now coloured
> >>
> >>>> using the tag colours rather than the
> marker
> >>>>
> >> colours.
> >>
> >>>> Nick.
> >>>>
> >>>>
>
> >>>>> --- En date de : Jeu 23.9.10, Benny
> Malengier
> >>>>>
>
> >> <[hidden email]>
> >>
> >>>>>
>
> >>>> a écrit :
> >>>>
>
> >>>>> De: Benny Malengier <[hidden email]>
> >>>>> Objet: Re: [Gramps-devel] GEPS 011:
> Tagging
> >>>>>
>
> >> update
> >>
> >>>>> À: "Helge@Gramps" <[hidden email]>
> >>>>> Cc: [hidden email]
> >>>>> Date: Jeudi 23 septembre 2010, 9h32
> >>>>>
> >>>>>
> >>>>>
> >>>>> 2010/9/22 Helge@Gramps <[hidden email]>
> >>>>>
> >>>>>
> >>>>>
> >>>>> Hi,
> >>>>>
> >>>>>
> >>>>>
> >>>>> I like the idea of tagging as started
> now for
> >>>>>
>
> >> people.
> >>
> >>>>> Because I did use markers in the past,
> here
> >>>>>
>
> >> this my
> >>
> >>>>>
>
> >>>> question: Did you think
> >>>>
>
> >>>>> about / plan a helper function
> >>>>>
>
> >>>> "add_TagIfNotYetAvailable " (or some
> thing
> >>>>
>
> >>>>> like this) using filters (e.g. based
> on
> >>>>>
>
> >> markers)? For
> >>
> >>>>>
>
> >>>> my opinion such a
> >>>>
>
> >>>>> function could be helpful to move from
> using
> >>>>>
>
> >> markers
> >>
> >>>>>
>
> >>>> today to use tags in
> >>>>
>
> >>>>> the future.
> >>>>>
> >>>>> I would advocate to remove Markers
> before
> >>>>>
>
> >> release, and
> >>
> >>>>>
>
> >>>> upgrade them to tags, if no use case is
> present
> >>>>
> >> anymore for
> >>
> >>>> markers in 3.3
>
> >>>>> So, personally I don't use markers, so
> I will
> >>>>>
>
> >> not miss
> >>
> >>>>>
>
> >>>> them. Are there people who still need
> markers for
> >>>>
> >> something
> >>
> >>>> once tags are present?
> >>>>
>
> >>>>> If no developer has a reason, we ask
> same
> >>>>>
>
> >> question on
> >>
> >>>>>
>
> >>>> the user list.
> >>>>
>
> >>>>> Benny
> >>>>>
> >>>>>
> >>>>> -Helge
> >>>>>
> >>>>>
> >>>>>
> >>>>> --
> >>>>>
> >>>>> View this message in context: http://gramps.1791082.n4.nabble.com/GEPS-011-Tagging-update-tp2549199p2551074.html
> >>>>>
> >>>>>
> >>>>> Sent from the GRAMPS - Dev mailing
> list
> >>>>>
>
> >> archive at
> >>
> >>>>>
>
> >>>> Nabble.com.
> >>>>
>
> >>>>>
>
> >>
> ------------------------------------------------------------------------------
> >>
> >>>>
>
> >>>>> Start uncovering the many advantages
> of
> >>>>>
>
> >> virtual
> >>
> >>>>>
>
> >>>> appliances
> >>>>
>
> >>>>> and start using them to simplify
> application
> >>>>>
>
> >>>> deployment and
> >>>>
>
> >>>>> accelerate your shift to cloud
> computing.
> >>>>>
> >>>>> http://p.sf.net/sfu/novell-sfdev2dev
> >>>>>
> >>>>>
> >>>>>
>
> >> _______________________________________________
> >>
> >>>>> Gramps-devel mailing list
> >>>>>
> >>>>> [hidden email]
> >>>>>
> >>>>> https://lists.sourceforge.net/lists/listinfo/gramps-devel
> >>>>>
> >>>>>
> >>>>>
> >>>>>
> >>>>> -----La pièce jointe associée
> suit-----
> >>>>>
> >>>>>
> >>>>>
>
> >>
> ------------------------------------------------------------------------------
> >>
> >>>>
>
> >>>>> Start uncovering the many advantages
> of
> >>>>>
>
> >> virtual
> >>
> >>>>>
>
> >>>> appliances
> >>>>
>
> >>>>> and start using them to simplify
> application
> >>>>>
>
> >>>> deployment and
> >>>>
>
> >>>>> accelerate your shift to cloud
> computing.
> >>>>> http://p.sf.net/sfu/novell-sfdev2dev
> >>>>> -----La pièce jointe associée
> suit-----
> >>>>>
> >>>>>
> >>>>>
>
> >> _______________________________________________
> >>
> >>>>> Gramps-devel mailing list
> >>>>> [hidden email]
> >>>>> https://lists.sourceforge.net/lists/listinfo/gramps-devel
> >>>>>
> >>>>>
> >>>>>
> >>>>>
>
> >>>>>
>
> >>
> ------------------------------------------------------------------------------
> >>
> >>>>
>
> >>>>> Start uncovering the many advantages
> of
> >>>>>
>
> >> virtual
> >>
> >>>>>
>
> >>>> appliances
> >>>>
>
> >>>>> and start using them to simplify
> application
> >>>>>
>
> >>>> deployment and
> >>>>
>
> >>>>> accelerate your shift to cloud
> computing.
> >>>>> http://p.sf.net/sfu/novell-sfdev2dev
> >>>>>
> >>>>>
>
> >> _______________________________________________
> >>
> >>>>> Gramps-devel mailing list
> >>>>> [hidden email]
> >>>>> https://lists.sourceforge.net/lists/listinfo/gramps-devel
> >>>>>
> >>>>>
> >>>>>
>
> >>>
> >>>
> >
> >
> >
> >
> >

jerome

Re: GEPS 011: Tagging update

> Something goes wrong with current ProgressMonitor use on gui/views/tags.py
>
> The progress bar displays 100% but did not commit all transactions! I made 1298 changes at once (add/remove tags).
>
> OK, '100% of selected handles' but not for the process...
> Same problem for "Removing Tags"
>
> I really get better performances by using ProgressMonitor after starting transactions.

setup debugging
2476: DEBUG: viewmanager.py: line 327: trying:
http://gramps-addons.svn.sourceforge.net/viewvc/gramps-addons/trunk/listings/addons-en.txt
2477: DEBUG: viewmanager.py: line 331: IOError!
2477: DEBUG: viewmanager.py: line 377: Done checking!
2736: DEBUG: htmlrenderer.py: line 142: webkit or/and mozilla (gecko)
is/are loaded : 1
2946: DEBUG: flatbasemodel.py: line 419: PersonListModel __init__ 0.0 sec
2951: DEBUG: listview.py: line 292: PersonListView build_tree 0.01 sec
2951: DEBUG: listview.py: line 297: parts 0.0 , 0.01 , 0.0 , 0.0 , 0.0
11585: DEBUG: flatbasemodel.py: line 419: PersonListModel __init__ 0.34 sec
11717: DEBUG: listview.py: line 292: PersonListView build_tree 0.47 sec
11718: DEBUG: listview.py: line 297: parts 0.34 , 0.02 , 0.11 , 0.0 , 0.0
28585: DEBUG: listview.py: line 292: PersonListView build_tree 1.43 sec
28586: DEBUG: listview.py: line 297: parts 1.19 , 0.01 , 0.02 , 0.21 , 0.0
86659: DEBUG: progressdialog.py: line 336: adding op to Progress Monitor
87201: DEBUG: progressdialog.py: line 355: heartbeat in ProgressMonitor
88153: DEBUG: progressdialog.py: line 355: heartbeat in ProgressMonitor
88444: DEBUG: progressdialog.py: line 355: heartbeat in ProgressMonitor
88831: DEBUG: progressdialog.py: line 355: heartbeat in ProgressMonitor
89157: DEBUG: progressdialog.py: line 355: heartbeat in ProgressMonitor
89510: DEBUG: progressdialog.py: line 355: heartbeat in ProgressMonitor
89823: DEBUG: progressdialog.py: line 355: heartbeat in ProgressMonitor
90026: DEBUG: progressdialog.py: line 355: heartbeat in ProgressMonitor
90315: DEBUG: progressdialog.py: line 355: heartbeat in ProgressMonitor
90575: DEBUG: progressdialog.py: line 355: heartbeat in ProgressMonitor
90812: DEBUG: progressdialog.py: line 355: heartbeat in ProgressMonitor
91062: DEBUG: progressdialog.py: line 355: heartbeat in ProgressMonitor
91265: DEBUG: progressdialog.py: line 355: heartbeat in ProgressMonitor
91746: DEBUG: progressdialog.py: line 355: heartbeat in ProgressMonitor
92001: DEBUG: progressdialog.py: line 355: heartbeat in ProgressMonitor
92217: DEBUG: progressdialog.py: line 355: heartbeat in ProgressMonitor
92457: DEBUG: progressdialog.py: line 355: heartbeat in ProgressMonitor
92648: DEBUG: progressdialog.py: line 355: heartbeat in ProgressMonitor
92886: DEBUG: progressdialog.py: line 355: heartbeat in ProgressMonitor
93055: DEBUG: progressdialog.py: line 355: heartbeat in ProgressMonitor
93790: DEBUG: listview.py: line 708: PersonListView row_update 0.36 sec
..
334690: DEBUG: listview.py: line 292: PersonListView build_tree 1.38 sec
334690: DEBUG: listview.py: line 297: parts 1.18 , 0.02 , 0.02 , 0.16 , 0.0

1298 tags : 0.36 sec is a very good score.
I do not know why I got so bad perfomance before!

Thanks.
Jérôme

jerome a écrit :

>> Until it is complete, to rename a tag you will have to
>> create a new one as follows:
>>
>> 1. Filter on the tag you want to rename.
>> 2. Select all rows with Ctrl-A.
>> 3. Tag the rows with a new tag name.
>> 4. Delete the old tag.
>
> Something goes wrong with current ProgressMonitor use on gui/views/tags.py
>
> The progress bar displays 100% but did not commit all transactions! I made 1298 changes at once (add/remove tags).
>
> OK, '100% of selected handles' but not for the process...
> Same problem for "Removing Tags"
>
> I really get better performances by using ProgressMonitor after starting transactions.
>
> - pmon.add_op(status)
> trans = self.db.transaction_begin()
> + pmon.add_op(status)
>
>
>
> Jérôme
>
> --- En date de : Ven 24.9.10, Nick Hall <[hidden email]> a écrit :
>
>> De: Nick Hall <[hidden email]>
>> Objet: Re: [Gramps-devel] GEPS 011: Tagging update
>> À: "jerome" <[hidden email]>
>> Cc: "Helge@Gramps" <[hidden email]>, "Benny Malengier" <[hidden email]>, [hidden email]
>> Date: Vendredi 24 septembre 2010, 22h41
>>
>>
>> jerome wrote:
>>> Thank you Nick,
>>>
>>> First step worked fine with your updated tool.
>>> Now I have a lot of tags (5000 tags, 15 types)!
>>> Playing with color, filter, remove action, etc ...no
>> problem Great work!
>>>
>> Thanks.
>>
>>> Still sometimes the Gtk color warning on console
>> gui/utils.py:320: GtkWarning: Don't know color `'
>>> gtk.main_iteration()
>>> QuestionDialog.py:136: GtkWarning: Don't know color
>> `'
>>> response = self.top.run()
>>> but no crash or error.
>>>
>>>
>> I am aware of this - http://www.gramps-project.org/bugs/view.php?id=1937
>>
>> I'll look at it when I have time. It shouldn't cause
>> a problem.
>>
>>> Maybe just a cosmetic issue.
>>> Is there a way for adding a space after comma on tag
>> list ? (PersonEditor) ?
>>> I looked at gen/lib/tagbase.py
>>> I suppose it is not safe because list should not have
>> a space ?
>>> I tought on someting like tag_list = ',
>> '.join(tag_list) but I cannot see where to only modify the
>> tag_list just for being displayed on PersonEditor!
>>>
>> It is just a cosmetic issue, but I think you are right that
>> it would look better with a space.
>>
>> I have added the space in r15927.
>>
>>> There is a limitation: we cannot rename the tag.
>>>
>> Yes, this is on my To-Do list. I also plan to add
>> tags to the context menus in the views.
>>
>>> But it should be possible to rename it into a Gramps
>> XML file.
>>>
>> I am working on the export and import at the moment.
>> Until it is complete, to rename a tag you will have to
>> create a new one as follows:
>>
>> 1. Filter on the tag you want to rename.
>> 2. Select all rows with Ctrl-A.
>> 3. Tag the rows with a new tag name.
>> 4. Delete the old tag.
>>
>>
>> Regards,
>>
>>
>> Nick.
>>>> _______________________________________________
>>>>
>>>>>>> Gramps-devel mailing list
>>>>>>> [hidden email]
>>>>>>> https://lists.sourceforge.net/lists/listinfo/gramps-devel
>>>>>>>
>>>>>>>
>>>>>>>
>>
>>>>>
>>>>>
>>>
>>>
>>>
>>>
>
>
>
>
> ------------------------------------------------------------------------------
> Start uncovering the many advantages of virtual appliances
> and start using them to simplify application deployment and
> accelerate your shift to cloud computing.
> http://p.sf.net/sfu/novell-sfdev2dev
> _______________________________________________
> Gramps-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/gramps-devel
>