Re: GET REQUESTS FOR: [gramps-project/addons-source] Select Form Dialogs fixes and improvements, inc search filtering

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: GET REQUESTS FOR: [gramps-project/addons-source] Select Form Dialogs fixes and improvements, inc search filtering

dbareis
Hi,

Can someone please have a look at "https://github.com/dbareis/DB_gramps_addons-source/pull/1" and tell me if that is the way to work on multiple branches at once or not.  I suspect not given that I've had no one comment on my pull request.

I have made a lot of bug fixes and improvements and at this stage, it doesn't look like anyone wants them.  If that is the case can someone please just say so?  

I was told to split them up, I was told I can work on multiple areas at once. As far as I can see I can only fork the repository once so that is not the way to do it.

There are plenty of other things I can be doing, I've spent over 3 times at much time to try to submit a fraction of what I have done than it took me to write and test just that fraction.

---
Thanks
Dennis


On Sun, 31 May 2020 at 14:50, Dennis Bareis <[hidden email]> wrote:
Hi,

In case you didn't get the message.   Can you please have a look at:  https://github.com/dbareis/DB_gramps_addons-source/pull/1  

That appears to be the only way I could be working on multiple things at once.

---
Thanks
Dennis


---------- Forwarded message ---------
From: Dennis Bareis <[hidden email]>
Date: Thu, 28 May 2020 at 09:10
Subject: Re: [gramps-project/addons-source] Select Form Dialogs fixes and improvements, inc search filtering (#351)
To: gramps-project/addons-source <[hidden email]>
Cc: gramps-project/addons-source <[hidden email]>, Mention <[hidden email]>


Hi,

I haven't given up yet but definitely close. Can you please have a look at:  https://github.com/dbareis/DB_gramps_addons-source/pull/1  

---
Thanks
Dennis

image.gif

Sender notified by
Mailtrack 28/05/20, 09:10:41 am

On Thu, 28 May 2020 at 08:40, Nick Hall <[hidden email]> wrote:

@dbareis If you decide to give up, perhaps you could email me the files for this change.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

image.gif

image.gif



image.gif
Sender notified by
Mailtrack 31/05/20, 02:50:05 pm
image.gif

image.gif
Virus-free. www.avast.com

<img width="0" height="0" alt="" style="display:flex" src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7">
Mailtrack Sender notified by
Mailtrack 03/06/20, 07:23:45 am


_______________________________________________
Gramps-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gramps-devel
Reply | Threaded
Open this post in threaded view
|

Re: GET REQUESTS FOR: [gramps-project/addons-source] Select Form Dialogs fixes and improvements, inc search filtering

GRAMPS - Dev mailing list
On 02/06/2020 22:24, Dennis Bareis wrote:
Can someone please have a look at "https://github.com/dbareis/DB_gramps_addons-source/pull/1" and tell me if that is the way to work on multiple branches at once or not.  I suspect not given that I've had no one comment on my pull request.


Almost. You have a branch in your fork.  Now you have to create a pull request to merge it into the main repository/



I have made a lot of bug fixes and improvements and at this stage, it doesn't look like anyone wants them.  If that is the case can someone please just say so? 


I think that your changes may be useful, but they will require a few changes.  In particular, I think that you should probably use the standard utility functions rather than extending them.  Also your debugging code shouldn't be part of the change.



I was told to split them up, I was told I can work on multiple areas at once. As far as I can see I can only fork the repository once so that is not the way to do it.


Correct.  One fork, multiple branches.



There are plenty of other things I can be doing, I've spent over 3 times at much time to try to submit a fraction of what I have done than it took me to write and test just that fraction.


I'm willing to help because I can see benefits in what you are trying to accomplish.


Nick.




_______________________________________________
Gramps-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gramps-devel