how to add mimetype to function media_link

classic Classic list List threaded Threaded
15 messages Options
Reply | Threaded
Open this post in threaded view
|

how to add mimetype to function media_link

Richard Bos-5
I trying (experimenting?) to extend the media_link function, so it can
make a difference between a document and a photo.  I have some
pdf documents in my galleries and those are not associate with a
good thumbnail (actually no thumnail at all).  My idea is to add an
argument to the medialink function:

File: plugins/NarrativeWeb.py
 532     def media_link(self,of,handle,path,name,up,usedescr=True):
 533         dirpath = self.build_path(handle,'img',up)
 534         of.write('<div class="thumbnail">\n')
 535         of.write('<p><a href="%s/%s.%s">' % (dirpath,handle,self.ext))
 536         of.write('<img src="../../../%s" ' % path)
 537         of.write('alt="%s" /></a></p>\n' % name)
 

so media_link(self,of,handle,path,name,up,usedescr=True) becomes:
media_link(self,of,handle,path,name,up,usedescr=True,mimetype)

and than the lines:
# grep -n media_link /opt/gnome/share/gramps/plugins/NarrativeWeb.py
371:                self.media_link(of,photo_handle,newpath,'',up=True)
402:                    self.media_link(of, photo_handle, newpath, descr, up=True)

become:
# grep -n media_link /opt/gnome/share/gramps/plugins/NarrativeWeb.py
371:                self.media_link(of,photo_handle,newpath,'',up=True,mime_type)
402:                    self.media_link(of, photo_handle, newpath, descr, up=True,mime_type)

However, when I do this gramps does not show the website generator in the menu.
So something is clearly wrong ;)  But what?  I'm not a python programmer as
you can notice, so hint in the right direction is appreciated.  Where can I find
gramps error messages?

Once mimetype is known to the media_link function it is possible
to do something like:

case mimetype in
  */pdf) of.write('<img src="../../../images/document.png ')

  *) of.write('<img src="../../../%s" ' % path)

esac

What would be the right way to do this in python?  Indeed
something with a 'case' or a 'select' statement, or would it
be better with 'if'?

--
Richard Bos
Without a home the journey is endless

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Gramps-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gramps-devel
Reply | Threaded
Open this post in threaded view
|

Re: how to add mimetype to function media_link

Brian Matherly
Richard,

<snip>
>However, when I do this gramps does not show the website generator in the menu.
>So something is clearly wrong ;)  But what?  I'm not a python programmer as
>you can notice, so hint in the right direction is appreciated.  Where can I find
>gramps error messages?

>From the help menu, select "plugin status". Then double click on the NarrativeWeb.py entry.

>Once mimetype is known to the media_link function it is possible
>to do something like:
>
>case mimetype in
>  */pdf) of.write('<img src="../../../images/document.png ')
>
>  *) of.write('<img src="../../../%s" ' % path)
>
>esac
>
>What would be the right way to do this in python?  Indeed
>something with a 'case' or a 'select' statement, or would it
>be better with 'if'?

I would probably use an "if" statement, myself. But either would work.

~Brian




-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Gramps-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gramps-devel
Reply | Threaded
Open this post in threaded view
|

Re: how to add mimetype to function media_link

Richard Bos-5
Op Friday 06 April 2007 21:43:06 schreef u:
> >However, when I do this gramps does not show the website generator in the
> > menu. So something is clearly wrong ;)  But what?  I'm not a python
> > programmer as you can notice, so hint in the right direction is
> > appreciated.  Where can I find gramps error messages?
>
> From the help menu, select "plugin status". Then double click on the
> NarrativeWeb.py entry.

:)

Now I get (when running gramps with my changes):
 File "/opt/gnome/share/gramps/plugins/NarrativeWeb.py", line 371, in
display_first_image_as_thumbnail
    self.media_link(of,photo_handle,newpath,'',mime_type,up=True)
TypeError: media_link() got multiple values for keyword argument 'up'

The change is attached, can you see what is wrong?


--
Richard Bos
We are borrowing the world of our children,
It is not inherited from our parents.

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Gramps-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gramps-devel

gramps.diff (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: how to add mimetype to function media_link

Richard Bos-5
Op Friday 06 April 2007 22:32:51 schreef Richard Bos:
> Now I get (when running gramps with my changes):
>  File "/opt/gnome/share/gramps/plugins/NarrativeWeb.py", line 371, in
> display_first_image_as_thumbnail
>     self.media_link(of,photo_handle,newpath,'',mime_type,up=True)
> TypeError: media_link() got multiple values for keyword argument 'up'
>
> The change is attached, can you see what is wrong?

found it.  The mimetype argument is to be placed before the up argument.

Attached the patch that displays the document icon when the file is a pdf
document.

The question now is, how to differentiate between a document and a picture in
more general, should it be like:
       if mimetype == document:
           path = 'images/document.png'
or
       if not mimetype == picture:
           path = 'images/document.png'

As there are a limited amount of picture formats (assume most common around
10), and there are much more other formats I promose to use the last one:

    if not mimetype == application/jpeg or mimetype == application/png or etc
           path = 'images/document.png'

Is there a handy construction for such thing in python?  Something equivalent
to bash' case statement?

case mimetype in
*jpg|*jpeg|*png) ...

*)
esac ??

--
Richard Bos
Without a home the journey is endless


-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Gramps-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gramps-devel

gramps.diff (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: how to add mimetype to function media_link

bm-5
Richard,

if you want to use icons in the output of GRAMPS, you might be interested in
reading:
http://www.gramps-project.org/wiki/index.php?title=Using_icons
and select an icon from
http://www.gramps-project.org/wiki/index.php?title=GRAMPS_icon_set

You will see some media icons you can use in the media types section.
These icons are for the 2.3 development branch, and I didn't upload all
of them
to SVN yet.

Be carefull with icons on your website that they are published under a FREE
license, so you can actually use them.

Benny

Quoting Richard Bos <[hidden email]>:

> Op Friday 06 April 2007 22:32:51 schreef Richard Bos:
>> Now I get (when running gramps with my changes):
>>  File "/opt/gnome/share/gramps/plugins/NarrativeWeb.py", line 371, in
>> display_first_image_as_thumbnail
>>     self.media_link(of,photo_handle,newpath,'',mime_type,up=True)
>> TypeError: media_link() got multiple values for keyword argument 'up'
>>
>> The change is attached, can you see what is wrong?
>
> found it.  The mimetype argument is to be placed before the up argument.
>
> Attached the patch that displays the document icon when the file is a pdf
> document.
>
> The question now is, how to differentiate between a document and a picture in
> more general, should it be like:
>       if mimetype == document:
>           path = 'images/document.png'
> or
>       if not mimetype == picture:
>           path = 'images/document.png'
>
> As there are a limited amount of picture formats (assume most common around
> 10), and there are much more other formats I promose to use the last one:
>
>    if not mimetype == application/jpeg or mimetype == application/png or etc
>           path = 'images/document.png'
>
> Is there a handy construction for such thing in python?  Something equivalent
> to bash' case statement?
>
> case mimetype in
> *jpg|*jpeg|*png) ...
>
> *)
> esac ??
>
> --
> Richard Bos
> Without a home the journey is endless
>
>



----------------------------------------------------------------
This message was sent using IMP, the Internet Messaging Program.

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Gramps-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gramps-devel
Reply | Threaded
Open this post in threaded view
|

Re: how to add mimetype to function media_link

Duncan Lithgow-2
> Be carefull with icons on your website that they are published under a FREE
> license, so you can actually use them.
examples at http://www.openclipart.org/ and http://creativecommons.org/image/

Do patches like this get automatically considered for inclusion? Or
what's the process? Richard - do you always submit your patches to the
tracker as enhancements? Of course I ask because I want the
functionality you're working on, and think most people would.

This also got me thinking about how to keep images out of reports -
luckily I went and checked and can see that every image has a
public/private record button. Those devs are always three steps ahead
of me! How does the License of the whole 'Narative Website' effect the
licenses of the individual images? Is it against the GNU license to
put the website under a restrictive license?

Duncan

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Gramps-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gramps-devel
Reply | Threaded
Open this post in threaded view
|

Re: how to add mimetype to function media_link

Don Allingham
If you want a patch considered, you should submit the patch to the bug
tracker. If it is a new feature, add it as a feature request. If it is a
bug fix, attach it to a bug report.

Email messages can get lost easily. I get bombarded with GRAMPS related
email every day, and to be honest, I don't have time to read and respond
to every message. I can easily get 40-80 messages a day. If I spend only
a minute or two on each message, it can take an hour or two to get
through email.

Things that go into the bug tracker are not forgotten. They may sit for
a while, but the purpose of the tracker is so the items can be tracked.

Don

On Sun, 2007-04-08 at 12:26 +0200, Duncan Lithgow wrote:

> > Be carefull with icons on your website that they are published under a FREE
> > license, so you can actually use them.
> examples at http://www.openclipart.org/ and http://creativecommons.org/image/
>
> Do patches like this get automatically considered for inclusion? Or
> what's the process? Richard - do you always submit your patches to the
> tracker as enhancements? Of course I ask because I want the
> functionality you're working on, and think most people would.
>
> This also got me thinking about how to keep images out of reports -
> luckily I went and checked and can see that every image has a
> public/private record button. Those devs are always three steps ahead
> of me! How does the License of the whole 'Narative Website' effect the
> licenses of the individual images? Is it against the GNU license to
> put the website under a restrictive license?
>
> Duncan
>
> -------------------------------------------------------------------------
> Take Surveys. Earn Cash. Influence the Future of IT
> Join SourceForge.net's Techsay panel and you'll get the chance to share your
> opinions on IT & business topics through brief surveys-and earn cash
> http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
> _______________________________________________
> Gramps-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/gramps-devel

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Gramps-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gramps-devel

signature.asc (198 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: how to add mimetype to function media_link

Brian Matherly
In reply to this post by Richard Bos-5
>> Be carefull with icons on your website that they are published under a FREE
>> license, so you can actually use them.
>examples at http://www.openclipart.org/ and http://creativecommons.org/image/
>
>Do patches like this get automatically considered for inclusion? Or
>what's the process? Richard - do you always submit your patches to the
>tracker as enhancements? Of course I ask because I want the
>functionality you're working on, and think most people would.

I usually ask people who create patches to attach them to an issue on the tracker. It REALLY HELPS when they submit each logical change as a separate patch and separate issue on the tracker. That way, the changes can be considered apart from each other rather than all together. Sometimes there is some debate about whether a patch is a feature enhancement or an actual bug. If I think it is really a bug, I do my best to apply it to the current branch as soon as I can. If I think it is a feature enhancement, I am a little more picky. I ask questions like this:
    Is this feature implemented in a general sense for all users, or specifically for the needs of the one who submitted the patch?
    Does anyone else want this feature, or will it unnecessarily complicate the code for the advantage of only one person?
    Is the feature well implemented, or is it "hacked" in?

What also REALLY HELPS is when other people examine the feature requests on the tracker and help answer the questions above. What I find most helpful are comments like this: "I would like this feature if it also . . . " or "I wouldn't like this feature because it would  . . . " or "This feature is perfect as-is and I fully support it". There are about a half dozen feature requests for the Narrative Website on the tracker right now that could use your opinion. You could consider it to be like voting.

Once I feel like a feature should be included, and I make time to do it, I apply the feature to the development branch (not the current branch). So you probably wouldn't see the feature until the next major release.

>This also got me thinking about how to keep images out of reports -
>luckily I went and checked and can see that every image has a
>public/private record button. Those devs are always three steps ahead
>of me! How does the License of the whole 'Narative Website' effect the
>licenses of the individual images? Is it against the GNU license to
>put the website under a restrictive license?

The license of the tool used to generate a work has no effect on the copyright of the work itself. This is no different than if you write a book using Open Office, or use WikiMedia to power your website. The content belongs to the author.

~Brian





-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Gramps-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gramps-devel
Reply | Threaded
Open this post in threaded view
|

Re: how to add mimetype to function media_link

Richard Bos-5
Op Sunday 08 April 2007 15:57:27 schreef Brian Matherly:
> There are about a half dozen feature requests for the Narrative Website on
> the tracker right now that could use your opinion. You could consider it to
> be like voting.

But they are hard to find, as the narrative website is not a component in the
bug tracker, it's just considered a plugin.  I actually think that the
narrative website deserves it's own component in the issue tracker.

--
Richard Bos
Without a home the journey is endless

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Gramps-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gramps-devel
Reply | Threaded
Open this post in threaded view
|

Re: how to add mimetype to function media_link

Richard Bos-5
In reply to this post by Brian Matherly
Op Sunday 08 April 2007 15:57:27 schreef Brian Matherly:

> What also REALLY HELPS is when other people examine the feature requests on
> the tracker and help answer the questions above. What I find most helpful
> are comments like this: "I would like this feature if it also . . . " or "I
> wouldn't like this feature because it would  . . . " or "This feature is
> perfect as-is and I fully support it". There are about a half dozen feature
> requests for the Narrative Website on the tracker right now that could use
> your opinion. You could consider it to be like voting.
>
> Once I feel like a feature should be included, and I make time to do it, I
> apply the feature to the development branch (not the current branch). So
> you probably wouldn't see the feature until the next major release.

The problem with waiting too long to respond is that the person that submitted
the bug forgets what and how he did what he did.  Or the person is than
occupied with another project or something like that.  It's better to respond
swift, to prevent such problems.

--
Richard Bos
We are borrowing the world of our children,
It is not inherited from our parents.

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Gramps-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gramps-devel
Reply | Threaded
Open this post in threaded view
|

Re: how to add mimetype to function media_link

bm-5
Richard,

if after 1 month or 6 months, you don't anymore know what a patch/feature
request/bug submit is for, or are not interested in it anymore, the
patch/feature is clearly not worthy of inclusion in GRAMPS or the bug not that
important.

This is exactly what the tracker is for: upstream maintainers keep some
distance, ask annoying questions,... . What users fight for/keep interest in,
is actually included.

My impression is that real bugs (with output) get solved quickly.
It is bugs which have bad description that don't get solved. GRAMPS is a
community project, to describe bugs good on the bug tracker is part of
the work
to get it better. The developers don't have time to spend hours trying to see
the same bug.

Benny

Quoting Richard Bos <[hidden email]>:

> Op Sunday 08 April 2007 15:57:27 schreef Brian Matherly:
>> What also REALLY HELPS is when other people examine the feature requests on
>> the tracker and help answer the questions above. What I find most helpful
>> are comments like this: "I would like this feature if it also . . . " or "I
>> wouldn't like this feature because it would  . . . " or "This feature is
>> perfect as-is and I fully support it". There are about a half dozen feature
>> requests for the Narrative Website on the tracker right now that could use
>> your opinion. You could consider it to be like voting.
>>
>> Once I feel like a feature should be included, and I make time to do it, I
>> apply the feature to the development branch (not the current branch). So
>> you probably wouldn't see the feature until the next major release.
>
> The problem with waiting too long to respond is that the person that
> submitted
> the bug forgets what and how he did what he did.  Or the person is than
> occupied with another project or something like that.  It's better to respond
> swift, to prevent such problems.
>
> --
> Richard Bos
> We are borrowing the world of our children,
> It is not inherited from our parents.
>
> -------------------------------------------------------------------------
> Take Surveys. Earn Cash. Influence the Future of IT
> Join SourceForge.net's Techsay panel and you'll get the chance to share your
> opinions on IT & business topics through brief surveys-and earn cash
> http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
> _______________________________________________
> Gramps-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/gramps-devel
>



----------------------------------------------------------------
This message was sent using IMP, the Internet Messaging Program.

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Gramps-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gramps-devel
Reply | Threaded
Open this post in threaded view
|

Re: how to add mimetype to function media_link

bm-5
In reply to this post by Duncan Lithgow-2
Quoting Duncan Lithgow <[hidden email]>:

>> Be carefull with icons on your website that they are published under a FREE
>> license, so you can actually use them.
> examples at http://www.openclipart.org/ and http://creativecommons.org/image/
>
> Do patches like this get automatically considered for inclusion? Or
> what's the process? Richard - do you always submit your patches to the
> tracker as enhancements? Of course I ask because I want the
> functionality you're working on, and think most people would.
>
> This also got me thinking about how to keep images out of reports -
> luckily I went and checked and can see that every image has a
> public/private record button. Those devs are always three steps ahead
> of me! How does the License of the whole 'Narative Website' effect the
> licenses of the individual images? Is it against the GNU license to
> put the website under a restrictive license?
>
> Duncan
>

The website has a specific copyright section. *USE IT*
Note further that content and images are under a different copyright. See
wikipedia or our wiki where the images are not GFDL but the text is. Duncun, a
feature request to add per picture a copyright notice (like on wiki) might be
interesting for legal reasons.

Concerning a patch to add images. I believe the images should be images
already
included in the GRAMPS installation. People knowing websites can then easily
replace those with what they want.

Benny

----------------------------------------------------------------
This message was sent using IMP, the Internet Messaging Program.

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Gramps-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gramps-devel
Reply | Threaded
Open this post in threaded view
|

Re: how to add mimetype to function media_link

Richard Bos-5
In reply to this post by bm-5
Op Monday 09 April 2007 12:15:12 schreef [hidden email]:
> if after 1 month or 6 months, you don't anymore know what a patch/feature
> request/bug submit is for, or are not interested in it anymore, the
> patch/feature is clearly not worthy of inclusion in GRAMPS or the bug not
> that important.

That's not what I stated.  If it takes too long, it is harder for the patch
provider to know why he solved it this way.  Like for me, with the patch I
provided I won't know why I had to swap the arguments in the function call.  
If you ask me now, I'll know next week I won't.  That does not mean that the
patch is bad or not desired (other people already expressed their wish to see
it included).  I'm involved in quite some projects so I know very well how to
deal with bugs/features reports/requests.

--
Richard Bos
We are borrowing the world of our children,
It is not inherited from our parents.

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Gramps-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gramps-devel
Reply | Threaded
Open this post in threaded view
|

Re: how to add mimetype to function media_link

Stéphane Charette-2
The other problem no-one has mentionned is the longer a patch sits,
the more likely there will be conflicts when it comes time to apply
it.

Stephane


On 4/9/07, Richard Bos <[hidden email]> wrote:

> Op Monday 09 April 2007 12:15:12 schreef [hidden email]:
> > if after 1 month or 6 months, you don't anymore know what a patch/feature
> > request/bug submit is for, or are not interested in it anymore, the
> > patch/feature is clearly not worthy of inclusion in GRAMPS or the bug not
> > that important.
>
> That's not what I stated.  If it takes too long, it is harder for the patch
> provider to know why he solved it this way.  Like for me, with the patch I
> provided I won't know why I had to swap the arguments in the function call.
> If you ask me now, I'll know next week I won't.  That does not mean that the
> patch is bad or not desired (other people already expressed their wish to see
> it included).  I'm involved in quite some projects so I know very well how to
> deal with bugs/features reports/requests.
>
> --
> Richard Bos
> We are borrowing the world of our children,
> It is not inherited from our parents.
>
> -------------------------------------------------------------------------
> Take Surveys. Earn Cash. Influence the Future of IT
> Join SourceForge.net's Techsay panel and you'll get the chance to share your
> opinions on IT & business topics through brief surveys-and earn cash
> http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
> _______________________________________________
> Gramps-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/gramps-devel
>

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Gramps-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gramps-devel
Reply | Threaded
Open this post in threaded view
|

Re: how to add mimetype to function media_link

Brian Matherly
In reply to this post by Richard Bos-5
I don't disagree that the sooner a feature patch is applied, the
better. But let me give you some perspective on how I prioritize my
precious Gramps time. I can't only speak for myself, but I suspect
other developers are similar.

Gramps Priorities for Brian:
1) Fix bug reports on the tracker that are concise, reproducible, and include a patch.
2) Fix bug reports on the tracker that are concise, reproducible, but don't include a patch.
3) Follow up with bug reports on the ML.
4) Work on features on the tracker that are well defined, justified and include a patch.
5) Work on features that I want to add or code refactoring to support future features.
6) Follow up with bug reports on the tracker that are not concise or reproducible.
7) Work on features on the tracker that are well defined, justified, but do not include a patch.
8) Work on features on the tracker that are not well defined or justified but include a patch.
9) Work on features on the tracker that are not well defined or justified and do not include a patch.

For
a feature to be "justified", I have to be convinced that the feature is
general enough and important enough that it will meet the needs of more
than just the feature requester. If you want to add a user option for
the ancestor chart to randomly reorder the letters in people's names,
you can forget about it. Because no one else will be interested in that
feature. Your best bet is to either: 1) generalize the feature so that
others might want to use it somehow, or 2) convince a different
developer - because I won't spend my time on it.

So as you can
see, your patch either falls in under priority 4 or priority 8
(depending on how well it is justified). But for the last two weeks, I
have been unable to get past priority 3.

Since I'm a volunteer,
if anyone wants me to do something for them, they need to motivate me.
The best way to do that is to move yourself up in my priority list. If
you are dealing with a bug, that means getting it on the tracker with a
description that makes it easy to reproduce (priority 2), or including
a patch (priority 1). If you are dealing with a feature, that means
getting on the tracker with a good definition and justification
(priority 7), or including a patch (priority 4).

I just thought you might enjoy a tiny window into my brain.

~Brian

>
>The other problem no-one has mentionned is the longer a patch sits,
>the more likely there will be conflicts when it comes time to apply
>it.
>
>Stephane
>
>
>On 4/9/07, Richard Bos <[hidden email]> wrote:
>> Op Monday 09 April 2007 12:15:12 schreef [hidden email]:
>> > if after 1 month or 6 months, you don't anymore know what a patch/feature
>> > request/bug submit is for, or are not interested in it anymore, the
>> > patch/feature is clearly not worthy of inclusion in GRAMPS or the bug not
>> > that important.
>>
>> That's not what I stated.  If it takes too long, it is harder for the patch
>> provider to know why he solved it this way.  Like for me, with the patch I
>> provided I won't know why I had to swap the arguments in the function call.
>> If you ask me now, I'll know next week I won't.  That does not mean that the
>> patch is bad or not desired (other people already expressed their wish to see
>> it included).  I'm involved in quite some projects so I know very well how to
>> deal with bugs/features reports/requests.
>>
>> --
>> Richard Bos
>> We are borrowing the world of our children,
>> It is not inherited from our parents.







-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Gramps-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gramps-devel